Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerize go-fmt #224

Closed
prestonvasquez opened this issue Oct 4, 2022 · 3 comments
Closed

Dockerize go-fmt #224

prestonvasquez opened this issue Oct 4, 2022 · 3 comments
Assignees
@gauravgahlot
Labels
enhancement New feature or request hacktoberfest non-go
Milestone
Eng Dependency Cl...

Comments

@prestonvasquez
Copy link
Contributor

prestonvasquez commented Oct 4, 2022 •
edited
Loading

It would be helpful to new engineers to dockerize go-fmt Make target and make it runnable with make fmt. This would require a very light-weight Go image with this installed:

go install mvdan.cc/gofumpt@latest

We should be able to run this with docker compose. Also update the docs/CONFIGURATION.md file to remove this required dependency.
@prestonvasquez prestonvasquez added this to the Eng Dependency Cleanup milestone Oct 4, 2022
@gauravgahlot
Copy link
Contributor

@prestonvasquez I got this one. Please assign.

@gauravgahlot gauravgahlot mentioned this issue Oct 5, 2022
Merged
@prestonvasquez
Copy link
Contributor Author

@gauravgahlot You're assigned

@ChandanChainani
Copy link

@prestonvasquez please close the issue has it been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gauravgahlot gauravgahlot

Labels
enhancement New feature or request hacktoberfest non-go
Projects
No open projects
Gidari MVP
Status: Done
Milestone
Eng Dependency Cleanup
Development

No branches or pull requests
3 participants
@prestonvasquez @gauravgahlot @ChandanChainani