Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move dockerfiles to a docker/ dir #241

Closed
prestonvasquez opened this issue Oct 6, 2022 · 3 comments
Closed

Move dockerfiles to a docker/ dir #241

prestonvasquez opened this issue Oct 6, 2022 · 3 comments
Assignees
@gauravgahlot
Labels
hacktoberfest

Comments

@prestonvasquez
Copy link
Contributor

prestonvasquez commented Oct 6, 2022 •
edited
Loading

Move the docker files in scripts/ to a docker/ directory. Update all makefile, scripts, and docker compose data to reflect this migration.
@prestonvasquez prestonvasquez mentioned this issue Oct 6, 2022
Closed
@prestonvasquez
Copy link
Contributor Author

This issue follows up on #225

@gauravgahlot
Copy link
Contributor

I got this one too @prestonvasquez. Ah, I so missed contributing to OSS. 😄

@gauravgahlot gauravgahlot mentioned this issue Oct 7, 2022
Merged
@gauravgahlot
Copy link
Contributor

@prestonvasquez Since you have a project setup, you should definitely consider project automation. Especially to auto-close issues when PR(s) are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gauravgahlot gauravgahlot

Labels
hacktoberfest
Projects
No open projects
Gidari MVP
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prestonvasquez @gauravgahlot