Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access_denied issue #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix access_denied issue #16

wants to merge 1 commit into from

Conversation

jblafage
Copy link

Hello,
I had access_denied error when I wanted to authenticate my application to our Ping Federate instance.
After some modifications on your code, it works fine.

I propose you the following modifications:

  • Change the way to use HttpClient object: as it is a disposable object, it's recommended to instantiate it only when you need to perform a call. So, I have defined methods for GET and POST calls on handler side instead of having a global httpclient at middleware level
  • I have also changed the UserName value when you retrieve user object, in order to map sub property when preferred_username property is not defined (our instance is configured to get only sub property)
  • I have changed the way to get assembly version, because I had an issue to clean assembly each time I compile after running the tool to generate NuGet package

… object is disposable), Map sub property as UserName when preferred_username is not defined, change method to get assembly version to avoid problems on compiling whith previous version of assembly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant