Suisin/test banner dark mode and mobile #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binary-com#12639) * chore: add total assets component and logic * chore: subscription and calculation * chore: cleanup * fix: typescript * chore: sonarcloud fix * chore: komen * chore: cleanup
* feat: cfd success screen * fix: remove unused * chore: komen * chore: add dxtradepasswordmodal * chore: remove unused * chore: remove unused * chore: cleanup * chore: komen
…#12727) * chore: added Description component * chore: applied nit
…om#12719) * chore: added titleicon component * chore: new changes * chore: updated the getAccountTitle into component * chore: rearrange types * chore: rename the const to PascelCase * chore: applied nit
Co-authored-by: DerivFE <fe-access@regentmarkets.com>
…ets (binary-com#12711) * fix: show the daily transfer limits for verified users when transferring between wallets * fix: replaced the correct limit key when showing limits between wallets * chore: empty commit
…' is not displaying (binary-com#12701) * fix: 🔧 error message not shown * fix: 🔧 change to warning color if the password valid * chore: ✨ add test
* fix: build error * fix: update component directory * fix: other issues
* chore: migrate FileUploaderComponent to typescript * fix: failing test cases * chore: added suggestions * chore: moved file-dropzone to p2p package * chore: moved truncateFileName from shared to utils file and added test cases * fix: regex potential DDos issue * chore: added suggestions * Update packages/p2p/src/components/file-dropzone/file-dropzone.tsx Co-authored-by: Niloofar Sadeghi <93518187+niloofar-deriv@users.noreply.github.com> * fix: import for types from file-dropzone * fix: flickering Icon on tab switch --------- Co-authored-by: Niloofar Sadeghi <93518187+niloofar-deriv@users.noreply.github.com>
…nary-com#10515) * fix: order complete toast message disappeares immediately * chore: keep the notification in notification centre after closing the toast notification * chore: reduce p2p_order_list calls * fix: reduce api call and issue notification not updated * chore: separate logic to hooks * refactor: 🧹 update test * fix: 🧹notification missing * fix: 🧹 failing test * fix: 🧹 check list length * fix: 🥸 sort the notifications since backend response could be unsorted * chore: ✨ separate p2p completed orders reaction to prevent deletion by other reaction * chore: ✨ checks to update orders info from subscription response * refactor: 🧹 simplify the code * fix: 🔧 first order completion disappear * refactor: 🔧 update comment * fix: ✨ notification still missing
…nputs on mobile (binary-com#12377) * refactor: 14 -> 10 max digits * refactor: 10 -> 12 * fix: a poc * fix: edge case * fix: tests * refactor: a minor change + tests
…sages (binary-com#12730) * fix: hide message for account pairs with unknown limits * chore: remove unused code
Co-authored-by: DerivFE <fe-access@regentmarkets.com>
* chore: update pop up modal to the follow the latest design * chore: change text to hintbox * chore: fix test cases * chore: revert icon files * chore: remove hard coded codes * chore: update account migration title * chore: update logic for account title * chore: update value to values
…urbos are unavailable (binary-com#12628) * feat: sort turbos first, if no turbos, - multipliers first * refactor: getSortedTradeTypes
…underlying files (binary-com#12313) * refactor: make a single market-underlying file in shared * test: market-underlying * refactor: use the only Validator class from shared * refactor: clean up * test: improve tests for validation-rules * test: packages/trader/src/Stores/Modules/Trading/Constants/validation-rules.ts * test: update tests for template in validator.ts * test: validator * test: validator * fix: sonarcloud * refactor: test for market-underlying * chore: remove unnecessary assertion
* chore: added carousel component * chore: removed the types * chore: removed the code smells * chore: added default value * chore: added default value v2
* chore: sent email content * chore: cleanup * chore: komen * chore: komen v2 * chore: remove unused * chore: komen
…om#12499) * chore: crs confirmation checkbox in real account creation * chore: crs confirmation checkbox in real account creation * chore: crs confirmation in mt5 account creation for non-npj countries * chore: reset css for crs checkbox
* feat: create real demo switch account on tradershub * fix: added first_real_accounts and demo_loginid inside useTradingAccountList * fix: resolve comments * chore: added open and closing animations when toggle * fix: resolve comments * fix: remove invalid classname * fix: remove headless and replace it with default tailwind * feat: create real demo switch account on tradershub * fix: added first_real_accounts and demo_loginid inside useTradingAccountList * fix: resolve comments * chore: added open and closing animations when toggle * fix: resolve comments * fix: remove invalid classname * fix: remove headless and replace it with default tailwind * chore: update code * fix: remove ButtonGroup export inside of ./components * fix: resolve build fail issue * fix: resolve sonar cloud issue * fix: add type to account * Delete packages/tradershub/package-lock.json
Co-authored-by: DerivFE <fe-access@regentmarkets.com>
… on the Buy/Sell Screen. (binary-com#12387) * chore: added currency title to dropdown * fix: background change for label
Co-authored-by: DerivFE <fe-access@regentmarkets.com>
…ed for Migrated and Migration eligble MT5 accounts (binary-com#12737) * fix: 🔧 wrong accountmigration badge in mt5 trade modal * refactor: 🧹 separate logic and change name * refactor: 🧹 change var name
* fix: updated strategy content * fix: dalembert dropdown
Co-authored-by: DerivFE <fe-access@regentmarkets.com>
…inary-com#12798) * fix: 🔧 onfido height and width for mobile * chore: ✨ add min-height for onfido
…verification) (binary-com#12765) * chore: ✨ show pending verification message upon mt5 account verification with pending poi and poa * fix: 🔧 failing tests * fix: 🔧 tradershub error
* chore: make tradershub r components responsive * fix: remove unused qtMerge
…f-limit (binary-com#12790) * fix: hide percentage message and selector fill when amount entered is invalid * chore: fix tests for WithdrawalCryptoPercentageSelector * chore: remove input validation check for percentage-selector
…and down on IPhone device (binary-com#12786) * fix: 🚑 fix bouncing of transfer header * style: 💄 fix overlapping * fix: 🥅 input console error
…-com#12768) * fix: used correct prop * chore: trigger rebuild
* chore: [TRAH]/mahdiyeh/2565/ctrader success modal * refactor: replace ModalStepWrapper with Modal Component * fix: directory * fix: the paths * fix: chnage color for dark theme, add titleClass to the ModalHeader * fix: change H3 to H5 * chore: remove modalStepWraper component * fix: remove Header * chore: remove isMobile * chore: remove unnecessary useEffect * chore: change the order in tailwind.config --------- Co-authored-by: Mahdiyeh Amirkhani <mahdiyehamirkhani@Mahdiyeh-Amirkhanis-Mac-J79XQHKXVJ-Standard.local>
* fix: PR test * fix: dash was missed --------- Co-authored-by: Mahdiyeh Amirkhani <mahdiyehamirkhani@Mahdiyeh-Amirkhanis-Mac-J79XQHKXVJ-Standard.local>
…s showing demo as default (binary-com#12775) * chore: add loader for currency switcher cause its showing demo as default * chore: komen * chore: komen v5 * chore: fix master
…binary-com#12828) * fix: disable eslint sorting keys inside of tailwind.config file * fix: revert tailwind.config and added eslintignore instead
…n with the design (binary-com#12766) * fix: 💄 button font size * style: 💄 fix button font ans height
…he green message does not align (binary-com#12813) * fix: 💄 fix gap * fix: 💄 refactor styles
* feat: added Trading App card loader * fix: fixed some of the stylings * fix: removed the redundant curly braces * fix: replaced the loader to the new directory * chore: added px-50 back to the stylings
…12112) * feat: Changed Header Icons for wallets * fix: fix css param value * fix: fixed responsive header and removed header divider
…-com#12827) * chore: Added currency switcher modal on mobile: - added modal id inside of AppContent - change ModalStepWrapper to Modal - change tailwind classes for Modal to accommodate responsive view * fix: made some changes to the tailwind classes to make the modal responsive * fix: made the loader full width for responsive
suisin-deriv
requested review from
matin-deriv,
maryia-deriv,
hirad-deriv,
amina-deriv and
yashim-deriv
as code owners
suisin-deriv
force-pushed
the
suisin/test-banner-dark-mode-and-mobile
branch
from
c71aa65
to
fcc3354
Compare
…into suisin/test-banner-dark-mode-and-mobile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Added banner for dark theme.
Screenshots:
Please provide some screenshots of the change.