Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dhruv/mt5 password modal styling/trah 3963 #116

Merged
merged 30 commits into from
Aug 29, 2024
Merged

Dhruv/mt5 password modal styling/trah 3963 #116

merged 30 commits into from
Aug 29, 2024

Conversation

Dhruv-deriv
Copy link

@Dhruv-deriv Dhruv-deriv commented Aug 23, 2024 •
edited
Loading

Changes:

  1. To style the new password modal in MT5-new Account creation
  2. To create the Mobile view for the new MT5 Account Creation Password model.
  3. Created test cases for Mt5CreatePassword Modal

Screenshot:

  1. Desktop view:
Screenshot 2024-08-29 at 9 55 22 AM
  1. Mobile view:
Screenshot 2024-08-29 at 9 55 48 AM
  1. Test cases
    Screenshot 2024-08-23 at 2 41 02 PM

@amina-deriv amina-deriv merged commit 0f39395 into amina-deriv:dhruv/amina_mt5_defaulting_jurisdiction Aug 29, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amina-deriv amina-deriv amina-deriv approved these changes

@fasihali-deriv fasihali-deriv fasihali-deriv approved these changes

@hirad-deriv hirad-deriv Awaiting requested review from hirad-deriv hirad-deriv is a code owner

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dhruv-deriv @amina-deriv @fasihali-deriv