Dhruv-Account Status Banner-TRAH-4030 #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… quick strategy (binary-com#16559) * fix: 🐛 Fixed empty tradetype field being shown in quick strategy form * test: ✅ Updated test suits
Co-authored-by: balakrishna-deriv <balakrishna-deriv@users.noreply.github.com>
…ader-v2 (binary-com#16506) * fix: invalid contractsfor calls * fix: chart needs active symbols to function * fix: temporary fix to rectify page not loading when values arent cached
…16486) * fix: purchase button background fix & adding box-shadow * revert: box shadow on purchase button is no longer required * feat: init Stake * feat: add stake/payout info to stake bottom sheet & purchase button fixes * chore: remove unused opacity as quill has been updated * refactor: util function getDisplayedContractTypes * feat: use local state to not hide info upon proposal error * chore: handle empty input error * fix: error handling - allow showing error initially * fix: initial value * fix: mult info * chore: max payout error handling * chore: displayed payout values state * fix: stake logic for rise/fall & higher/lower * refactor: logic refactoring * fix: stake styles * chore: styling & coloring * feat: add new error for max payout exceeded to purchase button * feat: use initial values from local storage for stake * refactor: StakeDetails * refactor: stake * test: Stake * test: add test for Stake basis * test: fix take-profit test * fix: show initial value in the Stake textbox * refactor: address comment * feat: prevent save action if proposal response has not been received yet * fix: address comment for comma in stake input * chore: allow input from numpad with comma that will be auto-replaced with dot
…inary-com#16429) * fix: cashier menu and header translations * fix: add preferred language and current language * fix: added deriv go to dependency * fix: added preferred language to dependency * fix: retrigger vercel
* fix: bump quill ui * fix: add expires on multiplier info * fix: move multipliers-expiration-info to tradeparams folder * fix: add barrier-info * fix: rename css and show parameter info according to design * fix: add payout per point info * fix: remove multiplier infos * fix: add animation to purchase and sell buttons * fix: failing tests * fix: add tests * fix: remove comment * fix: resolve comments * fix: animation issue when switching to another path * fix: change getTradeParams to object lookup and cleanup logic * fix: remove unused variable * fix: nest css variables * fix: shorten css declaration
…binary-com#16527) * fix: show invalid xml message when ivalid strategy is imported * chore: updated error message for invalid file * fix: invalid error for specific strategies
* fix: refactored bot functions * fix: removed commented code * fix: reverted code * fix: reverted code * fix: reverted code * fix: dark mode refresh theme sonar cloud * fix: for test case * fix: renamed functions * fix: added setLoading false on catch * fix: when strategies are empty * fix: loader when no strategies * fix: local file loaded to null on file upload * fix: test case * fix: for open on recent strategies * fix: for recent stratagies * fix: test cases and refactored load modal * fix: when there is no strategy updated * fix: updated test recent-workspace test case and naming for functions * fix: for cypress added disabled state for open * fix: for setting disabled button on active tab change * fix: for cypress loading strategy * fix: refactored onrecentworkspace click * fix: removed unused values --------- Co-authored-by: Farabi <102643568+farabi-deriv@users.noreply.github.com>
binary-com#16391) * feat: remove binary bot from deriv app * fix: finally remove binary type from wallets * fix: change text in unit test
…-com#16461) * fix: removed dashboard methods for changing top block colors * fix: summary panel dark theme color * fix: notifications for workspace change and block delete * chore: remove redundant setTimeout * fix: set reset button state to false after last blockly event
* fix: p2p toast message nick name fix * fix: optinal added * fix: optional chaining * fix: noti count filter
…ry-com#16149) * Ahmad/DTRA-1408/Fix Vanilla Contract in Contract Details V2 (binary-com#16018) * fix: decimal point * fix: currency in payoutperpoint * fix: vanillas * fix: only vanilla * fix: test coverage * Ahmad/DTRA-1405/Multipliers fix on Contract Details V2 (binary-com#16017) * fix: multiplier * fix: testcase * fix: fix * fix: deal cancel * chore: add DC * chore: suggestion * chore:fix * fix: test case fix * Ahmad/DTRA-1401/DTRA-1402/Add currency in payout per point and decimal point in take profit (binary-com#16012) * fix: decimal point * fix: currency in payoutperpoint * fix: vanillas * fix: test case and comments * chore: review fix * fix: indent --------- Co-authored-by: balakrishna-deriv <56330681+balakrishna-deriv@users.noreply.github.com> * fix: bugs with resetting filter and icon for hight low (binary-com#16003) Co-authored-by: balakrishna-deriv <56330681+balakrishna-deriv@users.noreply.github.com> * Akmal / fix: pass currency across closed positions and contract details (binary-com#16161) * fix: pass currency across closed positions and contract details * fix: add a comment * [DTRA]/Ahmad/DTRA-1490/Deal Cancellation Status Fix Trader-V2 (binary-com#16121) * fix: cancellation active, executed and expired * chore: revert last commit * DTRA-1569 / Kate / Filter resetting issue (binary-com#16359) * fix: resetting filter issue * refactor: add date clear on unmount * refactor: tests * fix: tests * fix: console error * Akmal / fix: wrong duration unit for digit contracts (binary-com#16378) * fix: wrong duration unit for digit contracts * fix: test case * Akmal / fix: take profit & stop loss decimals (binary-com#16195) * fix: remove decimals from take profit * fix: apply fixes from quill library * fix: apply dynamic decimal places based on currency * feat: update quill-ui version --------- Co-authored-by: ahmadtaimoor-deriv <129935294+ahmadtaimoor-deriv@users.noreply.github.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com>
* fix: add leave page modal * fix: show leavePageModal in responsive * fix: test
* chore: cfd success unit test * chore: update test cases
…ry-com#16581) * feat: add margin for banner * feat: add margin to banner child
…binary-com#16135) * [WALL] george / WALL-4519 / Support XRP Deposits and Withdrawals in Wallets (binary-com#42) * refactor(wallets): ♻️ refactor wallets deposit/withdraw visibility * fix(wallets): 🚑 fix playwright tests * feat(wallets): ✨ add UI elements for XRP integration (binary-com#43) * feat(wallets): ✨ add UI elements for XRP integration * style: 💄 remove dark background * fix: 🚑 prevent crypto_config call for doughflow providers * fix: hardcode min withdrawal value for xrp * fix: withdrawalCryptoValidator min value * fix: withdrawalCryptoValidators min withdrawal value * fix: get min value from fractional digits --------- Co-authored-by: lubega-deriv <lubega@deriv.com>
…ashier (binary-com#15992) * refactor(cashier): ♻️ refactor cashier deposit/withdraw visibility * chore: apply comment * refactor(cashier): ♻️ extract crypto_config reuqest from useCurrencyConfig hook * feat(appstore): ✨ refactor one time deposit relying on cashier provider * fix: hardcode min withdrawal value for xrp * fix: deposit-crypto-disclaimers unit test * fix: get min value from fractional digits * test(cashier): 🧪 fix test * fix(cashier): 🧪 fix sonarcloud issue --------- Co-authored-by: lubega-deriv <lubega@deriv.com>
…com#16557) * refactor: reverted to production header for dtrader v2 * fix: fixed failing tests * fix: fixed margin top error for dtrader-v2 header * fix: removed dtrader-v2 classname from app-content
* chore: Refactor Trading App Card component in Wallets * chore: fix existing css issues for components using TradingAppCard * chore: update styles and remove unused classNames and scss stylesheets * chore: update test case * chore: update component with data-testid * chore: update options component with deriv app account * fix: retrigger vercel * chore: fix eslint * chore: fix test case
…als/guide-content (binary-com#16543) * test: [Test Coverage] Folder: bot-web-ui/src/pages/tutorials/guide-content * chore: fix a sonar cloud issue * refactor: split the test case * refactor: guide content test * chore: add tabIndex
…inary-com#16550) * chore: update test cases for faq-content file * fix: scroll on faq accordion expand * chore: added reused strings into variables * chore: increase coverage to 100%
…ent creates a new duplicate account (DoB + Phone Number) (binary-com#16301) * feat: add error message for cashier * feat: add error sketch * feat: add same-dob-phone-number-modal * feat: close real account signup if dob and phone are duplicated
Co-authored-by: DerivFE <fe-access@regentmarkets.com>
…com/ui (binary-com#16568) * chore: replace wallets action screen * fix: eslint * fix: applied comments * fix: subtasks raised * Update trade-type-list.spec.jsx * Update account-wizard.jsx * fix: failed workflow * fix: ts error * fix: ts error
Co-authored-by: DerivFE <fe-access@regentmarkets.com>
Dhruv-deriv
requested review from
matin-deriv,
maryia-deriv and
amina-deriv
as code owners
* test: improve guide-content * test: improve guide-content(1) * test: improve guide-content(2) * chore: rename variables, remove unnecessary waitFor
* fix: server bot empty name save issue fix * fix: dont allow spaces as value * fix: remove extra validation
…om#16692) * chore: add testid * test: add unit tests for jurisdication screen * chore: remove unnecessary beforeeach * chore: remove unnecessary assertion
…iv-com/ui (binary-com#16565) * chore: replce WalletCheckbox with Checkbox from deriv-com/ui * chore: remove WalletCheckbox from wallets package
…6662) * fix: add missing crowdin strings * fix: removed unused localize * fix: remove unused useTranslations * fix: add localize for tooltip contents * fix: mt5 redirect options * fix: failing workflow
* fix: trader's hub link underline fix * fix: trader's hub link underline fix
…ary-com#16570) * chore: added logic to show the correct video based on language selected * chore: updated current language from useTranslations to commmon store * chore: update video-player to support rtl * chore: added arabic video * chore: added key for seamless translations * chore: updated values within video-player component
amina-deriv
reviewed
Sep 3, 2024
Comment on lines
+23
to
24
| background-color: var(--status-warning-transparent); | ||
| } |
There was a problem hiding this comment.
this will effect all classes. we need to make sure only "pending" class is effected
amina-deriv
reviewed
Sep 3, 2024
| @@ -8,10 +8,9 @@ | |||
| padding: 2px 7px; | |||
| color: var(--status-info); | |||
| border-radius: 4px; | |||
| border: 1.5px solid var(--status-info); | |||
There was a problem hiding this comment.
this will effect all badges @Dhruv-deriv
* fix: link color in account settings page * chore: revert icon file * chore: add fix for risk-management-info-modal test case
Co-authored-by: DerivFE <fe-access@regentmarkets.com>
* chore: added action to open live chat * chore: add client info to live chat
…ionality (binary-com#16473) * feat: init risk management descriprion * feat: add content dependency * feat: add segmented control for deal cancellation * refactor: moved risk managament content into a separate component * feat: create deal cancellarion wheel picker with toggle switch * feat: add save functionality for dc * refactor: revert default value and clean up css * fix: layout height adjastment * refactor: add max height for strike, growth rate and risk management * feat: add time units * feat: add deal cancel fee info * feat: add snackbar for dc save * refactor: add skeleton loader for wheel picker and add tests for description parts * refactor: add tests for dc * refactor: add tests for utils * refactor: multiplier actionsheet height for small device * refactor: mulripliers dc info * fix: tp bug with replacement * refactor: move validation to BE * refactor: combained ba and fe validation * chore: commented tests * fix: input validation * refactor: create reg exp for input value * refactor: integrate mary changes * refactor: move validation to be again * fix: add tp and has tp to localstorage * feat: integrate tp into risk management * fix: tests for take profit * refactor: add tests for tp input * refactor: add comments and refactor tp * chore: rename componnets * refactor: add loader for dc and fix the condition for showing acc range * refactor: make input with tp reusable for sl * refactor: update quill and refactor dc component * refactor: rewrite with the usage of preview propoasl * refactor: removed initial wheel picker values for risk management * fix: order of checks in save function * feat: add acceptable range for multipliers rick management * refactor: final tuning * refactor: prevent user from saving before we got an * fix: regexp * refactor: add tests for new files * refactor: apply sugestions * refactor: preview proposal * refactor: update quill and reg exp replacement logic * chore: clean up code smells * refactor: apply suggestions * refactor: remove extra forget calls * chore: remove unused ref * revert: extra non-aligned file from master * revert: extra non-aligned file from master
…dex was turned off from BO (binary-com#16705) * refactor: add bo disabling text on purchase button * refactor: add conditional rendering and loader for acc info and barroer info and added tests * refactor: purchase button
Co-authored-by: DerivFE <fe-access@regentmarkets.com>
Dhruv-deriv
requested review from
hirad-deriv,
yashim-deriv and
vinu-deriv
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the Status banner with the updated design
Screenshots:
1.