Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utkarsha/refinement api token accounts #86

Conversation

utkarsha-deriv
Copy link
Collaborator

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@utkarsha-deriv utkarsha-deriv marked this pull request as ready for review August 31, 2023 07:03
@coveralls
Copy link

coveralls commented Aug 31, 2023

Pull Request Test Coverage Report for Build 6144619231

  • 69 of 79 (87.34%) changed or added relevant lines in 10 files are covered.
  • 1809 unchanged lines in 47 files lost coverage.
  • Overall coverage increased (+0.02%) to 10.326%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/account/src/Components/api-token/api-token-context.ts 1 2 50.0%
packages/api/src/hooks/useApiToken.ts 8 9 88.89%
packages/core/src/Stores/ui-store.js 0 1 0.0%
packages/api/src/hooks/useGetApiToken.ts 0 3 0.0%
packages/api/src/hooks/useSetApiToken.ts 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
packages/account/src/Components/api-token/api-token-clipboard.tsx 5 71.7%
packages/cfd/dist/cfd/js/CFDDbviOnBoarding.js 24 0.0%
packages/cfd/dist/cfd/js/CFDFinancialStpRealAccountSignup.js 24 0.0%
packages/cfd/dist/cfd/js/CFDPasswordModal.js 24 0.0%
packages/cfd/dist/cfd/js/CFDResetPasswordModal.js 24 0.0%
packages/cfd/dist/cfd/js/CFDServerErrorDialog.js 24 0.0%
packages/cfd/dist/cfd/js/CFDTopUpDemoModal.js 24 0.0%
packages/cfd/dist/cfd/js/CompareAccountsModal.js 24 0.0%
packages/cfd/dist/cfd/js/JurisdictionModal.js 24 0.0%
packages/cfd/dist/cfd/js/MT5TradeModal.js 24 0.0%
Totals Coverage Status
Change from base Build 6142957541: 0.02%
Covered Lines: 10518
Relevant Lines: 85931

💛 - Coveralls

@github-actions
Copy link

Generating Lighthouse report...

@amina-deriv
Copy link
Owner

Nicely done. LGTM 👌

Copy link
Collaborator

@matin-deriv matin-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, LGTM 👍🏼

@utkarsha-deriv utkarsha-deriv merged commit d099693 into amina-deriv:accounts_team/accounts_package_ts_migration/sprint_6 Sep 12, 2023
1 check passed
amina-deriv added a commit that referenced this pull request Oct 29, 2023
…for-dark-mode

Utkarsha/migration banner for dark mode
amina-deriv pushed a commit that referenced this pull request Aug 5, 2024
…-API-for-verification-SMS-Whatsapp

feat: integrate phone number challenge api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants