Shaheer/sprint 6 ts migration master merge #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oid) (binary-com#10518) * chore: added mobile link for cTrader * refactor: remove useless fragment code smell * chore: added QRCode for cTrader * chore: updated the QRCode link * chore: re-added real flags * chore: hide iOS icon with temporary banner on apple devices
…iser profile after manual refresh (binary-com#9569) * fix: fix issues when refreshing advertiser and my-profile page * fix: sendbird error in test files * refactor: prevent destructuring error when response is undefined * fix: failed tests * fix: block overlay doesnt show the advertiser name * chore: empty commit * chore: epmty commit
binary-com#10551) * chore: removed help centre from account-limits-article and updates testcases * chore: refactor accounts-limit-article
…iles in Trader package (binary-com#10574) * refactor: add tests for contract audit spec * refactor: add tests for contract audit item * refactor: add tests for contract history file * refactor: started refactoring existing test for contract details * refactor: refcator existiing tests for contract details * refactor: test cases for contract audit * fix: grammar * fix: more grammar errors
binary-com#10564) * feat: add new label for multipliers * feat: add styling as per design * fix: style for widget for non allowed symbols * fix: translation bug and apply suggestions
* fix: turbos changes cherry picked * fix: test case * fix: test cases * fix: change to localize component * fix: failing test cases and resolved comments * fix: amend glossary content * fix: amend turbos description * fix: modify failing test case * fix: minor content changes * fix: amend failing test * fix: scroll bar overlapping content on firefox * fix: remove changes for firefox
…downTimer in Trader package (binary-com#10594) * refactor: add test for market is closed overlay file * refactor: started adding tests for market countdowntimer * refactor: market countdown timer test file * refactor: description of the case * refactor: apply suggestions * refactor: remove act from imports
…Trader package (binary-com#10678) * refactor: add tests for trade params file * refactor: add tests for trade params mobile file * refactor: change test cases description * chore: grammar
… open to file picker (binary-com#10406)" (binary-com#10636)" (binary-com#10638)" (binary-com#10641)" (binary-com#10662) This reverts commit 9959d1a.
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
…nary-com#10706) * refactor: moved jurisdiction screen and modal to cfd folder * refactor: moved jurisdiction screen and modal to cfd folder * chore: used base text and button components for jurisdiction modal * Update JurisdictionModal.tsx * chore: moved jurisdiction card into folder
…0739) * refactor: moved jurisdiction screen and modal to cfd folder * refactor: moved jurisdiction screen and modal to cfd folder * chore: used base text and button components for jurisdiction modal * Update JurisdictionModal.tsx * chore: moved jurisdiction card into folder * feat: added verifications status for back card * chore: fix eslint issues * chore: fix eslint issues * chore: fix eslint issues * chore: updated prop types for jurisdiction * chore: refactor code based on reviews
* feat: cashier withdrawal email verification * chore: import useState * chore: remove hook and use hook from usehooks-ts * fix: images path * refactor: styles
…0744) * chore: code cleanup and change to WalletText * chore: update type to CSSProperties
* backup * chore: backup working poc flows * feat: added flow provider to wallets * chore: reverted different changes * chore: reverted different changes * chore: reverted different changes * chore: reverted icons * chore: fix eslint issues for docs * chore: fix eslint issues for docs * Update AccountFlow.tsx * Update AccountFlow.tsx * chore: fixed eslint issues * feat: added screen ordering * chore: fix eslint issues * chore: fix eslint issues * chore: fix eslint issues * chore: added more docs and updated context * chore: fix eslint
* chore: Updated button component to include Wallet Text and Icon * fix: resolve comments * fix: resolve comments * fix: added fullwidth * fix: remove WalletText * fix: remove WalletText in AvailableMT5AccountList
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
* feat: initial add hooks * feat: complete next poi step * chore: added comments
* feat: install joyride to wallets package * feat: add useFeatureFlag to the onboarding component of header * feat: complete 2 steps * feat: add one comment * feat: add color red for WalletText and update Tooltip * feat: add CSSProperties['color'] to WalletText * feat: delete unnecessary styles and change span to WalletText * refactor: delete unnecessary style * feat: hide onboardng button * refactor: cleanup * feat: delete package-lock.json * fix: delete useState import
…binary-com#10765) * chore: code cleanup and add routing for internal platforms * fix: sort eslint
* fix: use poi hook * fix: forwarded data so it can be extended
* fix: remove duplicate types in base * fix: rename type as types * fix: ghost button styling * fix: change omit to exclude
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
* feat: add hotjar to core * refactor: move initHotjar call to app.jsx * fix: mockstore * chore: add domain restriction
…#10314) * refactor: 🚚 migrates js test file to tsx * feat: ✨ adds connected apps earn more section * refactor: 🎨 updates connected apps know more section * refactor: 🎨 removes unused icon * refactor: 🚚 migrates index js to ts * feat: ✨ adds connected apps empty component * refactor: 🎨 refactors article section * style: 💄 refactors classname * refactor: 🚚 migrates test file from jsx to tsx * refactor: 🎨 refactors empty connected apps component * style: 💄 cleans account styling for connected apps component * refactor: 🎨 refactors connected apps section * fix: 🐛 fixes typescript warnings * refactor: 🎨 refactors connected apps screen * test: 🧪 adds test for connected apps component * test: 🧪 adds missing test to article component * test: 🧪 adds test for earn more section * refactor: 🎨 refactors connected apps component * test: 🧪 adds test for know more section * test: 🧪 adds test for connected apps empty component * test: 🧪 adds test for data list template entry * test: 🧪 adds test for data list template * refactor: 🎨 refactors connected apps component * refactor: 🎨 refactors tsx file * test: 🧪 adds test for useOauthConnectedApps hook * test: 🧪 adds test for useOAuthRevokeConnectedApps hook * test: 🧪 updates connected apps test file * feat: dumy * feat: added case with atleast one connected app * chore: review changes * style: 💄 updates style * refactor: 🎨 removes unwanted observer * refactor: 🎨 uses react fragment instead of div * feat: empty commit * feat: empty commit * fix: make the desktop design similar to figma * fix: 🐛 fixes code review issues * fix: 🐛 fixes as per code review comments * revert: 🚑 reverts hook usage due to mobx api clash * revert: 🚑 reverts hook implementation due to mobx api sync issue * refactor: 🗑️ clean up index file * test: 🧪 updates test cases * style: 💄 updates info component text size based on responsiveness * refactor: 🗑️ removes unused import * test: 🧪 fixes test case * refactor: 🎨 refactors code based on code review * refactor: 💄 moves styling to local style file * refactor: 🎨 passes prop directly * refactor: 🎨 creates a common bullet ol component * test: 🧪 updates test cases * refactor: 🎨 refactors bullets ol list * test: 🧪 updates test file * fix: 🐛 sets loading screen based on error in BE response * refactor: 🎨 passes classnames directly * refactor: 🎨 updates article component to take Localize --------- Co-authored-by: sanjam chhatwal <sanjam@deriv.com> Co-authored-by: sanjam-deriv <99465624+sanjam-deriv@users.noreply.github.com>
* feat: Created Icon Button for wallets package * fix: added ref and remove unnecessary imports
* feat: add key files from prev tech tebt branch * feat: add digits file from prev branch * feat: add contract types file from prev branch * feat: add trade params mobile from prev branch * fix: remove duplicates * Maryia/dtra-401/TS migration: multiplier components (#34) * chore: migrate cancel-deal to ts * chore: migrate expiration & expiration modal * chore: migrated multiplier * chore: migrate stop-loss * chore: migrate take-profit * chore: migrate widgets * build: trigger build with empty commit * Kate / DTRA-398 / TS migration: Widget components in Trader package (#33) * refactor: ts of contract replay widget * refactor: ts of mobile widgets * refactor: ts of chart widgets * refactor: ts of top widgets * refactor: ts of top widgets * refactor: types for widgets * refactor: apply suggestions * refactor: add position prop * fix: extention of the imported file * chore: replace some localizes (#36) * Kate / DTRA-400 / [Refactoring]: delete duplicated unused files from Markers folder in Trader package and migrate to TS marker.jsx (#37) * refactor: marker folder * fix: change file extension in test * Kate / DTRA-404 / [Refactoring]: Divide trade-categories.tsx file and cover changes with tests (#35) * refactor: add rise fall description * refactor: separate stay end high contract description * refactor: separate description of digits contracts * refactor: separate asian reset runhighlow touch contracts * refactor: separate callputspread lb tickhighlow and vanilla contracts * refactor: separate multipliers contract * refactor: add unit tests for contract descriptions * refactor: add more tests * refactor: add tests for touch ans vanilla contracts * refactor: tests for trade categories * refactor: contract description structure * refactor: apply suggestions * refactor: add missing test case * Maryia/DTRA-403/feat: migrate Routes files in Trader package to TS (#38) * feat: migrate routes files to ts * fix: routes extension * refactor: for consistency * refactor: import order * refactor: renamed prop types * refactor: type for consistency * refactor: remove index as key * fix: ts migrate settingsmodal and remove unused file (#39) * fix: ts migrate settingsmodal and remove unused file * fix: failing tests * Kate/ fix: code smells (#40) * fix: code smells * chore: empty commit * fix: function arguments * refactor: tests * fix: codesmells * refactor: code smells * chore: change optional chaining * refactor: tests * refactor: tests for widgets component * fix: tests * fix: conflicts * fix: more conflicts * fix: tests * refactor: add more test cases * fix: types in tests * fix: test extention * fix: return turbos back to types * fix: revert unplanned files * fix: code smells (#42) * fix: test extention * fix: bug with inserting objecting into the backticks * fix: file extention after ts migration * chore: sort imports * chore: revert file * chore: revert wallet changes * chore: remove extra file * chore: apply nit * fix: language switching issue with the chart --------- Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com>
* chore: Fix UI issues in Add More Wallets carousel - updated buttons with IconButton - updated scss file for WalletsAddMoreCarousel file - fix small ui issues in mobile view * chore: fix wallet action button on mobile - replace with IconButton component - make scss file changes accordingly * fix: resolve comments
…ept Multipliers) (binary-com#10826) * refactor: make cards consistance * refactor: remove some multipliers limitations and commited code * refactor: add unit tests * refactor: unit tests * refactor: apply suggestions
…tion (binary-com#11081) * feat: fiat withdrawal module * fix: applied comments * fix: resolved failed test
…nent (binary-com#11145) * style: 💄 fix icon xl size, jurisdiction badge, text xl line-height size * style: 💄 add gap in mobile view * style: 🎨 replace svg fiat currency icons with proper ones
…th Deal Cancellation (binary-com#11057) * fix: pnl in multipliers card * test: add tests + make indicator the same as in reports
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
* test: add test case for settings.js * fix: mobile - remove extra spacing below run button * fix: duration field validation error is not displayed when switching the duration type * fix: remove the text cursor on mobile as we have disabled the keyboard * fix: unable to see typed texts on the Quick Strategy Field * Revert "fix: unable to see typed texts on the Quick Strategy Field" This reverts commit 513abf4. * Revert "fix: remove the text cursor on mobile as we have disabled the keyboard" This reverts commit e5f948a. * Revert "fix: duration field validation error is not displayed when switching the duration type" This reverts commit d9039fe. * Revert "fix: mobile - remove extra spacing below run button" This reverts commit 520eef1.
…nt size with Figma (binary-com#11180) * fix: transaction status font size * fix: `TransactionStatus` no transactions * fix: "No recent transactions" font size also updated * refactor: remove useless usememos, add `isTransactionStatusSuccessVisible`
* ci: remove circleci production workflow * build: remove circleci config test module
* feat: updated Textfield component * chore: added inputClassNames for customizability for different situations and edit css * fix: resolve comments
…com#10993) (binary-com#11146) * feat: quick-strategy - add max stake with updated martingale (binary-com#10993) * feat: quick-strategy - add max stake with updated martingale * feat: quick-strategy - max-stake style done * feat: quick-strategy field alignment done * feat: quick-strategy - adding max-stake and related settings * feat: quick-strategy max-stake and contract-type implementation * feat: quick-strategy max-stake and contract-type coverage * feat: quick-strategy max-stake - made tradetype fullwidth * feat: quick-strategy styles cleanup * feat: quick-strategy max_stake should be less than initial stake * feat: quick-strategy coverage and TS cleanup * feat: quick-strategey max_stake qs-input coverage correction * feat: quick-strategey max_stake qs-input coverage correction cleanup * Farabi/quick-strategy-initial-stake-issue (binary-com#11151) * fix: removed unit field * fix: initial stake Nan issue and trade type style * fix: qs-duration-style (binary-com#11176) --------- Co-authored-by: Farabi <102643568+farabi-deriv@users.noreply.github.com>
shaheer-deriv
requested review from
matin-deriv,
maryia-deriv,
hirad-deriv,
amina-deriv and
yashim-deriv
as code owners
shaheer-deriv
merged commit 5b7503f
into
accounts_team/accounts_package_ts_migration/sprint_6
1 check failed
amina-deriv
pushed a commit
that referenced
this pull request
Aug 5, 2024
…when_phone_number_otp_invalid Suisin/chore: implement phone number otp api hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.