Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource minio_s3_bucket_notification #55

Open
aminueza opened this issue Mar 4, 2020 · 0 comments
Open

Add resource minio_s3_bucket_notification #55

aminueza opened this issue Mar 4, 2020 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@aminueza
Copy link
Owner

aminueza commented Mar 4, 2020

Add a new resource to manage buckets notifications.

Some rules to follow:

  • add a new tag in provider.go: minio_s3_bucket_notification;

  • add an object in payload.go file named as
    type S3MinioNotification struct

  • create a func in check_config.go to fill up the object structure:
    func S3NotificationConfig

  • check terraform example;

  • check go code for AWS s3 notification;

  • add a test file naming as minio_s3_notification_test.go and follow the same template for test written in resource_aws_s3_notification_test.go;

  • update the documentation creating a new S3_BUCKET_NOTIFICATION.md file;

  • create a .tf file with an example in examples/bucket/bucket.tf;

@aminueza aminueza added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant