Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable users to click and drag anywhere within a block, if block contains text require a double click to edit text. #2783

Closed
MackenzieHartung opened this issue Jul 10, 2019 · 8 comments · Fixed by #2863
Labels
Enhancement New feature or improvement of an existing one
Milestone

Comments

@MackenzieHartung
Copy link

As a user I want to be able to click anywhere on a block, and drag/place it elsewhere on a page.

AC1: Single clicking anywhere on a block, and dragging will drag a block.
AC2: Upon release block will remain in new place.
AC3: Double clicking within a text block will enable edit-mode.

@swissspidy
Copy link
Collaborator

For reference, here's how they implemented the clickthrough feature for inner blocks in Gutenberg: WordPress/gutenberg#15537

@swissspidy
Copy link
Collaborator

Do we have an item somewhere for an Instagram-like focus when editing a text block? I wonder whether that might be useful here too.

@miina
Copy link
Contributor

miina commented Aug 6, 2019

By instragram-like focus do you mean that the rest of the screen is faded out and the text appears in the center instead of its actual position?

@swissspidy
Copy link
Collaborator

Yes. Perhaps just with the fading out, without the position change.

@miina
Copy link
Contributor

miina commented Aug 6, 2019

I don't think we have an issue for that, the only related issue was displaying the selected block on top of the other blocks (couldn't find the issue right now).

We could create a consideration issue for that, it could be useful in some cases. Might also be useful when rotating elements which are close to each other.

I guess this would need testing to see if it makes sense for desktop editing.

@miina
Copy link
Contributor

miina commented Aug 20, 2019

Instructions for testing:

  • Create a Text block
  • Verify that the block can be dragged from anywhere.
  • Verify that clicking twice on the block will allow editing the Text and disable dragging.
  • Verify that deselecting the block will disable the edit mode and allow dragging again.

@csossi
Copy link

csossi commented Aug 20, 2019

Verified in QA

@csossi csossi removed their assignment Aug 20, 2019
@cathibosco
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement of an existing one
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants