Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github "Custom domain" settings are cleared after deployment #38

Closed
takahser opened this issue May 29, 2018 · 2 comments
Closed

github "Custom domain" settings are cleared after deployment #38

takahser opened this issue May 29, 2018 · 2 comments

Comments

@takahser
Copy link

takahser commented May 29, 2018

When using custom domains on github pages, the "custom domain" settings are cleared after building and publishing an angular app. After setting the custom domain in the settings manually again, the page would work, but it would be more convenient, if the custom domain settings would remain unchanged when deploying.

update

Found this: tschaub/gh-pages#213

Apparently, the solution is to add a CNAME file to the root directory which contains the custom domain in case of manual deployment. So I checked the local gh-pages branch which contains that file with the corresponding domain name. However, the remote origin/gh-pages branch doesn't contain any CNAME file for some reason. It seems like its not getting pushed for some reason during deployment.

@JohannesHoppe
Copy link
Member

Jep. see https://github.com/angular-schule/angular-cli-ghpages/wiki/FAQ#my-cname-file-is-deleted-on-every-publish-specific-to-github-pages-only

When I have some time, I will add the paramter --cname

@takahser
Copy link
Author

lovely! thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants