Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Commit

Permalink
fix(list): fix clipping on list items, simplify code
Browse files Browse the repository at this point in the history 
closes #2199
  • Loading branch information
@rschmukler
rschmukler committed Sep 24, 2015
1 parent acbf293 commit 9759440
Showing 1 changed file with 9 additions and 7 deletions.
16 changes: 9 additions & 7 deletions src/components/list/list.scss
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
$list-h3-margin: 0 0 6px 0 !default;
$list-h4-margin: 10px 0 5px 0 !default;
$list-h3-margin: 0 0 0px 0 !default;
$list-h4-margin: 3px 0 1px 0 !default;
$list-h4-font-weight: 400 !default;
$list-header-line-height: 0.75em !default;
$list-header-line-height: 1.2em !default;
$list-p-margin: 0 0 0 0 !default;
$list-p-line-height: 1.6em !default;

Expand All @@ -21,10 +21,10 @@ $list-item-primary-avatar-width: $baseline-grid * 5 !default;
$list-item-primary-icon-width: $baseline-grid * 3 !default;
$list-item-secondary-left-margin: $baseline-grid * 2 !default;
$list-item-secondary-button-width: $baseline-grid * 6 !default;
$list-item-text-padding-top: $baseline-grid * 2 !default;
$list-item-text-padding-bottom: $baseline-grid * 2.5 !default;
$list-item-inset-divider-offset: 12 * $baseline-grid !default;
$list-item-height: 6 * $baseline-grid !default;
$list-item-two-line-height: 9 * $baseline-grid !default;
$list-item-three-line-height: 11 * $baseline-grid !default;

md-list {
display: block;
Expand Down Expand Up @@ -169,10 +169,11 @@ md-list-item.md-2-line > .md-no-style,
md-list-item.md-3-line,
md-list-item.md-3-line > .md-no-style {
align-items: flex-start;
justify-content: center;

This comment has been minimized.

Sign in to view

Copy link
@sydneyhenrard

sydneyhenrard Nov 29, 2015

Any reason why the content is centered? Why not justify-content: flex-start

.md-list-item-text {
flex: 1;
padding: $baseline-grid * 2 0;
margin: auto;
text-overflow: ellipsis;

&.md-offset {
Expand Down Expand Up @@ -211,6 +212,7 @@ md-list-item.md-3-line > .md-no-style {

md-list-item.md-2-line,
md-list-item.md-2-line > .md-no-style {
height: $list-item-two-line-height;
> .md-avatar:first-child {
margin-top: $baseline-grid * 1.5;
}
Expand All @@ -219,12 +221,12 @@ md-list-item.md-2-line > .md-no-style {
}
.md-list-item-text {
flex: 1;
padding-top: ($baseline-grid * 2.5) - 1;
}
}

md-list-item.md-3-line,
md-list-item.md-3-line > .md-no-style {
height: $list-item-three-line-height;
> md-icon:first-child,
> .md-avatar:first-child {
margin-top: $baseline-grid * 2;
Expand Down

0 comments on commit 9759440

Please sign in to comment.