Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Commit

Permalink
fix(select): properly hide the progressbar
Browse files Browse the repository at this point in the history
The loader in `md-select` is being shown/hidden via the `$$loadingAsyncDone` property. Initially it is `undefined`, which causes the loader to continue rendering in the background, until the user opens and closes the select.

Fixes #8379.

Closes #8381
  • Loading branch information
crisbeto authored and ThomasBurleson committed May 19, 2016
1 parent 10e4712 commit 9e1e202
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/components/select/select.js
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ function SelectDirective($mdSelect, $mdUtil, $mdTheming, $mdAria, $compile, $par
.find('md-content')
.prepend(angular.element(
'<div>' +
' <md-progress-circular md-mode="indeterminate" ng-if="!$$loadingAsyncDone" md-diameter="25px"></md-progress-circular>' +
' <md-progress-circular md-mode="indeterminate" ng-if="$$loadingAsyncDone === false" md-diameter="25px"></md-progress-circular>' +
'</div>'
));

Expand Down Expand Up @@ -550,7 +550,7 @@ function SelectMenuDirective($parse, $mdUtil, $mdTheming) {
var selectCtrl = ctrls[0];

element.addClass('_md'); // private md component indicator for styling

$mdTheming(element);
element.on('click', clickListener);
element.on('keypress', keyListener);
Expand Down

0 comments on commit 9e1e202

Please sign in to comment.