Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Commit

Permalink
fix(select): remove correct controller from formCtrl w/ name
Browse files Browse the repository at this point in the history
closes #3062, closes #3671
  • Loading branch information
rschmukler committed Jul 12, 2015
1 parent 1478628 commit ed6b45c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/components/select/select.js
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ function SelectDirective($mdSelect, $mdUtil, $mdTheming, $mdAria, $interpolate,

if (attr.name && formCtrl) {
var selectEl = element.parent()[0].querySelector('select[name=".' + attr.name + '"]');
formCtrl.$removeControl(angular.element(selectEl).controller());
formCtrl.$removeControl(ngModelCtrl);
}


Expand Down

1 comment on commit ed6b45c

@hodeyp
Copy link

@hodeyp hodeyp commented on ed6b45c Jul 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rschmukler it looks as if this change has removed the ability to monitor required for an input. All of my 'ng-messages' are no longer firing in $error?

Please sign in to comment.