Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Autocomplete suggestions remain at same position onScroll #2973

Closed
asaharan opened this issue May 25, 2015 · 9 comments
Closed

Autocomplete suggestions remain at same position onScroll #2973

asaharan opened this issue May 25, 2015 · 9 comments

Comments

@asaharan
Copy link

While typing if we scroll position of suggestion remain fixed
See the gap between input box and suggestion box
screenshot from 2015-05-25 17 41 55

@ThomasBurleson ThomasBurleson modified the milestone: Backlog May 28, 2015
@rschmukler rschmukler changed the title onScroll suggestions remain at same position Autocomplete suggestions remain at same position onScroll May 28, 2015
@matthieuh
Copy link

+1

@krassx
Copy link

krassx commented Jun 9, 2015

Same here. Tried with 0.9.8.
http://gyazo.com/b7dcb0f28acd5568c259a3a453b9ac9e

@cpae
Copy link

cpae commented Jun 9, 2015

+1 (v. 0.10.0)

@SriramaDanturthi
Copy link

+1

@epelc
Copy link
Contributor

epelc commented Jun 12, 2015

@robertmesserle How does this work if the input isn't visible when it gains focus? For example if you tab to an auto complete while you are scrolled past it. This sounds like it'd lock the view and be very hard to understand for the user.

@robertmesserle
Copy link
Contributor

@epelc This is modeled after the way that select components work in Chrome on Mac. The screen is only locked when the select menu is showing. The browser should move the input into view when the user focuses it, but I'm going to spend some time today trying to break this and see if I can find any edge cases that need to be addressed. If you find any examples where this breaks, please send a CodePen my way.

@epelc
Copy link
Contributor

epelc commented Jun 12, 2015

@robertmesserle Thanks. I was just going off the changelog info I didn't get to test it in my app yet. I'm waiting for a good time to update #2710 so I can get it merged soon. I've been running a fork for several weeks with that pr so I haven't been able to easily update and test the later 0.9.X and 0.10.X releases. I'll let you know if I find anything though.

@robertmesserle
Copy link
Contributor

@epelc Interestingly, my description of how the browser would handle it worked in 0.9.8, but when tested against master just now, doesn't seem to move as expected. Might need to add a delay before locking scrolling to account for the browser's build-in functionality.

@robertmesserle
Copy link
Contributor

Confirmed, that fixed it. Committing to master now. Good call! =p

@Splaktar Splaktar removed this from the - Backlog milestone Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants