Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

$mdDialog: weird bug if dialog pops when browser tab is not focused, cannot close the dialog #3916

Closed
dani3l opened this issue Jul 27, 2015 · 10 comments
Assignees
Milestone

Comments

@dani3l
Copy link

dani3l commented Jul 27, 2015

Hi guys

I found out a weird bug - sometimes, I cannot close the dialog with .cancel() / .hide()
I noticed it happened when dialog pops when browser tab is not focused, but it doesn't happend everytime.

In addition - when the bug happens, the dialog onComplete function is not fired.

I'm using 0.10.1-rc3 and latest angular 1.4.4 (bug happens also with angular1.4.3)


Update:
I downgraded to 0.10.0 (and 0.10.1-rc1) and it behaves ok.
so rc2 and rc3 are buggy


Another issue is the dialog animation in rc3 is choppy

@ThomasBurleson ThomasBurleson changed the title Weird bug with $mdDialog - If dialog pops when browser tab is not focused, cannot close the dialog $mdDialog: weird bug if dialog pops when browser tab is not focused, cannot close the dialog Jul 28, 2015
@ThomasBurleson ThomasBurleson added this to the 0.10.1 milestone Jul 28, 2015
@ThomasBurleson ThomasBurleson self-assigned this Jul 28, 2015
@Tyrannmisu
Copy link

I also experienced this issue, but i could not figure out when it occurs.
Sometimes i just cant close/hide a dialog.

@ThomasBurleson ThomasBurleson modified the milestones: 0.10.1, 0.11.0 Jul 31, 2015
@ramanathan92
Copy link

I had a problem like when i open md-dialog and close it,afterwards click event is not triggering in my page(simply nothing is working after i close dialog,again if i tries to open it is not opening)

@ThomasBurleson
Copy link
Contributor

@Tyrannmisu, @ramanathan92 - please retry with the latest code base from master. Please provide a CodePen if this persists. Here are some starter demo templates that you can use/fork:

@ramanathan92
Copy link

Thanks @ThomasBurleson .It is my fault(my bad).Actually, I added scope: $scope when calling dialog but forgot to add preserveScope: true.That is the reason, it is not allowing me to open dialog.

@Tyrannmisu
Copy link

I did not experience this issue in 0.10.1-rc4 and rc5 for a long time now. :)
But i will have a look on master.

@EladBezalel
Copy link
Member

@Tyrannmisu Can you please check it on HEAD to see if the problem still occurs?

@Tyrannmisu
Copy link

Sry i totaly forgot to post here. 🙈
I did not experience this issue since 0.10.1-rc4 nether on HEAD nor on the official releases.
I would say its fixed.

@lexyfeito
Copy link

Good morning i am having the same exact issue right now, doesnt anyone have a fix?
I am using v1.0.3-master-b707375

@EladBezalel
Copy link
Member

@lexyfeito please check on head, if it's still happening please post a codepen and I will reopen

@lexyfeito
Copy link

So i finally figure out the problem, event was being sent undefiened. Stupid me :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants