-
Notifications
You must be signed in to change notification settings - Fork 3.4k
md-dialog not showing ng-message properly #4291
Comments
Same issue, below is the dialog I have. The textarea label changes color as well as the md-maxlength value but as for the ng-message text it never shows. Removing md-maxlength doesn't resolve the issue either.
|
@ThomasBurleson is this a bug in md-dialog and ng-messages ? I think a lot of people are using md-dialog with input fields and field validation should work. Thx a lot for your efforts around angular material. |
+1 |
Based on the comment of #2820 I have solved some issues with the dialogs.
The CSS style defines the position as absolute which does not work in our md-dialogs. When changing it to relative they are shown properly. Hope that helps to fix this in the libs |
@kschwidder I have no issues with using form validation in mdDialog. Can you make a plunker so I can see? |
@kschwidder I have a PR (#5123) to add some info to the docs about optional dependencies. Additionally, we made some changes to the way messages were shown including using Please post a comment including a Codepen (using the latest master versions) which demonstrates the issue if you are still having problems and we will reopen. Here are some links if you need them:
|
Tried using the RAWGIT, but looks like the issue is still unresolved.ng-message is till not shown properly inside md-dialog |
I'm experiencing the same issue. ng-message works like a charm inside my page but not when used inside a dialog. |
I was able to fix the issue with the following CSS overrides
Then add an ng-show to suppress it from always showing until certain conditions were met |
Has someone found a hotfix for it in the angular-material source? |
The problem is caused, apparently, by our dialog having form tags and, theoretically, they are inside another form tags from the main page. |
I have the following dialog defined with some input fields.
In the plunker I can correctly run only the form which show the ng-messages properly.
When embedding it into a dialog, the ng-messages does not show up.
What am I missing ?
The text was updated successfully, but these errors were encountered: