Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Inability to add custom layout breakpoints #5020

Closed
pmowrer opened this issue Oct 5, 2015 · 4 comments
Closed

Inability to add custom layout breakpoints #5020

pmowrer opened this issue Oct 5, 2015 · 4 comments
Assignees
@ThomasBurleson
Labels
P5: nice to have These issues will not be fixed without community contributions. ui: flexbox
Milestone
Deprecated

Comments

@pmowrer
Copy link

pmowrer commented Oct 5, 2015

Prior to 0.11.0, it was relatively easy to add custom breakpoints (e.g. xs in our case as we're transitioning away from bootstrap) using the sass mixins that define the defaults.

As of 0.11.0, this method no longer works as layouts became directives. I think it'd still be pretty easy to do, only the methods used to create the directives aren't publicly accessible and would have to be copy/pasted.

I can understand if this is not a design goal of Angular Material, but I thought I'd put it out there in case.
@ThomasBurleson
Copy link
Contributor

Great suggestion... and interestingly enough this feature is already in planning ;-)

@ThomasBurleson ThomasBurleson added this to the 0.12.0 milestone Oct 5, 2015
@ThomasBurleson ThomasBurleson self-assigned this Oct 5, 2015
@pmowrer
Copy link
Author

pmowrer commented Oct 5, 2015

Glad to hear that! Thanks for the update and keep up the great work!

@ThomasBurleson
Copy link
Contributor

With SHA a4a5644, we now publish the Layout features with Attribute Selectors [only] in the CSS file: angular-material.layouts.css. When using this file:

  • Developers should also use <body md-layout-css > to disable the Layout JS engine with its attribute selector conversions to classnames.
  • NOTE: !! Attribute selectors cause significant performance degradations in IE

Future releases will allow developers to use the Layout Javascript (without the external SCSS/CSS) engine to configure breakpoints and even attach callbacks for custom notifications when the mediaQuery changes.

@ThomasBurleson ThomasBurleson added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Oct 15, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 0.12, 0.13 Oct 15, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc2, 1.0-rc3 Oct 30, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc3, 1.0-rc4 Nov 7, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc4, 1.0-rc5 Nov 16, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc5, 1.0-rc8 Nov 25, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0.3, 1.0.2 Jan 7, 2016
@ThomasBurleson ThomasBurleson added P5: nice to have These issues will not be fixed without community contributions. and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs priority: high labels Jan 13, 2016
@ThomasBurleson ThomasBurleson removed this from the 1.0.3 milestone Jan 13, 2016
@ThomasBurleson ThomasBurleson changed the title Inability to add custom layout breakpoints as of 0.11.0 Inability to add custom layout breakpoints Jan 13, 2016
@chrisguerrero chrisguerrero mentioned this issue Jan 15, 2016
Closed
@ThomasBurleson ThomasBurleson modified the milestone: Backlog Jan 15, 2016
@ThomasBurleson ThomasBurleson modified the milestones: Backlog, Features Apr 21, 2016
@ThomasBurleson
Copy link
Contributor

This issue is closed as part of our ‘Surge Focus on Material 2' efforts.
For details, see our forum posting @ http://bit.ly/1UhZyWs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ThomasBurleson ThomasBurleson

Labels
P5: nice to have These issues will not be fixed without community contributions. ui: flexbox
Projects
None yet
Milestone
Deprecated
Development

No branches or pull requests
3 participants
@ThomasBurleson @pmowrer @jelbourn