Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Setting height value for flex in column layout #937

Closed
jintoppy opened this issue Dec 13, 2014 · 2 comments
Closed

Setting height value for flex in column layout #937

jintoppy opened this issue Dec 13, 2014 · 2 comments

Comments

@jintoppy
Copy link

I can give flex to specify how much space I want for a child.

<div layout="row">
  <div flex="66" flex-sm="33">
    I flex to one-third of the space on mobile, and two-thirds on other devices.
  </div>
  <div flex="33" flex-sm="66">
    I flex to two-thirds of the space on mobile, and one-third on other devices.
  </div>
</div>

However, I think, if the layout is column, and if we give flex values to the child, it should give height, not width.

For eg.

<div layout="column">
  <div flex="66" flex-sm="33">
    I flex to one-third of the space on mobile, and two-thirds on other devices.
  </div>
  <div flex="33" flex-sm="66">
    I flex to two-thirds of the space on mobile, and one-third on other devices.
  </div>
</div>

In this, the height should be 66% for the first child. However, flex is just considering width only for now irrespective of the layout given.

Please let me know your thoughts.

Thanks

@jintoppy jintoppy changed the title Setting flex for height in column layout Setting height value for flex in column layout Dec 13, 2014
@ajoslin
Copy link
Contributor

ajoslin commented Dec 15, 2014

You're absolutely correct!

@PaulMougel
Copy link
Contributor

Related to #836?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants