Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Disable rules for aXe #14

Closed
angela-choo opened this issue Dec 13, 2016 · 7 comments
Closed

Disable rules for aXe #14

angela-choo opened this issue Dec 13, 2016 · 7 comments

Comments

@angela-choo
Copy link
Contributor

angela-choo commented Dec 13, 2016

I'm trying to disable rules inside protractor.conf.js for aXe but does not seem to work. Please see my code below. Thank you!

plugins: [{
        axe: ({
            rules:{
                "aria-required-children": { "enabled": false },
                "color-contrast": { "enabled": false }
            }
        }),
        package: 'protractor-accessibility-plugin'
    }],

Also raised question here: dequelabs/axe-core#267

@sjelin
Copy link
Contributor

sjelin commented Dec 15, 2016

It appears that we're not passing on the information in the axe property to . Would you be interested in writing this feature yourself? I think you'd just want to change this part to:

  AxeBuilder(browser.driver)
    .options(context.axe.options)
    .analyze(function(results) {
      deferred.resolve(results);
    });

@jamsea
Copy link
Contributor

jamsea commented Dec 15, 2016

@angela-choo and @sjelin I started working on this functionality here: https://github.com/nfl/protractor-accessibility-plugin/tree/feature/configAXE I've been pulled off this though and won't have time to get back to it until the new year. This might help you out

@angela-choo
Copy link
Contributor Author

@jamsea Great, I will take a look at it!

@sjelin Sure, would be happy to work on this feature.

@angela-choo
Copy link
Contributor Author

@sjelin added the feature and submitted PR here: #15 I am wondering once the PR is approved, when will be the next release? Thanks!

@sjelin
Copy link
Contributor

sjelin commented Dec 19, 2016

I can do a release whenever

@sjelin
Copy link
Contributor

sjelin commented Dec 20, 2016

0.3.0 released! Thanks for the PR

@sjelin sjelin closed this as completed Dec 20, 2016
@rolandjitsu
Copy link

Note that if you provide both:

axe: {
    runOnly: {},
    rules: {}
}

rules is ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants