Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add ReleaseFrame func like Gav1Decoder #39

Closed
FongMi opened this issue Nov 9, 2023 · 8 comments
Closed

Please add ReleaseFrame func like Gav1Decoder #39

FongMi opened this issue Nov 9, 2023 · 8 comments

Comments

@FongMi
Copy link

FongMi commented Nov 9, 2023

image

image

@anilbeesetti
Copy link
Owner

@FongMi Could you explain what you mean and why this function is important

@FongMi
Copy link
Author

FongMi commented Nov 13, 2023

My player interface can adjust the ExtensionRendererMode at any time. As long as it is changed from EXTENSION_RENDERER_MODE_PREFER to EXTENSION_RENDERER_MODE_ON, an error will occur.

Using DefaultRenderersFactory it won't happen.

So I think it is when the player has been released, but ffmpeg did not receive the notification to release, causing the decoder error.

@anilbeesetti
Copy link
Owner

@FongMi It's the issue with surface as mentioned in google/ExoPlayer#9459

@FongMi
Copy link
Author

FongMi commented Nov 13, 2023

I see.
It's exo problem.

@FongMi FongMi closed this as completed Nov 13, 2023
@anilbeesetti
Copy link
Owner

Hey @FongMi. Just wanted to let you know that I kinda solved this issue by recreating the surface everytime video switches decoder. Implementation is in this PR:- anilbeesetti/nextplayer#785

@FongMi
Copy link
Author

FongMi commented Feb 16, 2024

Thanks, I will test again.

@FongMi
Copy link
Author

FongMi commented Jun 4, 2024

@anilbeesetti have u try to use TextureView ?

Screen will not update, and keep same frame.

@FongMi
Copy link
Author

FongMi commented Aug 16, 2024

Hey @FongMi. Just wanted to let you know that I kinda solved this issue by recreating the surface everytime video switches decoder. Implementation is in this PR:- anilbeesetti/nextplayer#785

androidx/media#1591

I have tested this pr, it does not need to recreate the surface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants