Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regarding the branche name #167

Closed
sky-joker opened this issue Aug 2, 2020 · 16 comments
Closed

Regarding the branche name #167

sky-joker opened this issue Aug 2, 2020 · 16 comments

Comments

@sky-joker
Copy link
Contributor

SUMMARY

It looks like the collections branch name decided to change master to main by Ansible maintainer.

see:

I create this issue for we don't forget.

@D3DeFi
Copy link
Contributor

D3DeFi commented Aug 4, 2020

Do we want to rename it? If yes, before 1.0.0?

@sky-joker
Copy link
Contributor Author

If possible that I think desirable that we should rename the current branch before the 1.0.0 release.
If we would like to change the current branch name I wonder we need to request to @gundalow?
After confirming with Settings, I had not to privilege of changing the branch name.

@gundalow
Copy link
Collaborator

gundalow commented Aug 4, 2020

Do we want to rename it? If yes, before 1.0.0?

Yes before 1.0.0 would be clearnen

@sky-joker You now have the powers, be careful 👍

https://github.com/ansible/community/wiki/Changing-the-git-default-branch-to-main has the steps in

@sky-joker
Copy link
Contributor Author

I checked that I have the privilege of changing the branch name.
Thank you @gundalow for giving privilege.

@D3DeFi
Copy link
Contributor

D3DeFi commented Aug 8, 2020

Thank you for handling this @sky-joker @gundalow

Feel free to change this whenever (just notify us on Gitter). Handful of developers we are we can survive this change without any major announcements :)

Edit: @sky-joker this seem to be a requirement for 2.10 release, see #170. Can you make it until then?

@sky-joker
Copy link
Contributor Author

sky-joker commented Aug 9, 2020

@D3DeFi

First, I'm going to check the changing branch name procedure with my GitHub test repository by the end of the day or tomorrow.
If the procedure is no problem, I will do a consultation for the date of changing the branch name.

@sky-joker
Copy link
Contributor Author

While looking at the renaming procedure, I tried the renaming branch name succeeded with my GitHub test repository :)
I think this project will be of the renaming repo name procedure the following.

  • create the main branch
  • change the main to the default branch
  • if exists PR to the master, change to the main
  • remove the master branch

We need to decide on the implementation date of the branch renaming.

@D3DeFi @dj-wasabi

Do you have a preferred implementation date?

@D3DeFi
Copy link
Contributor

D3DeFi commented Aug 9, 2020

Maybe if you have time to quickly go through all of the PRs from @dj-wasabi as I think they are ready to be merged and then? For example sometime tomorrow?

I dont really mind the date as long as it suits you.

@D3DeFi
Copy link
Contributor

D3DeFi commented Aug 9, 2020

While looking at the renaming procedure, I tried the renaming branch name succeeded with my GitHub test repository :)

Also many thanks for looking into this! 🚀

@sky-joker
Copy link
Contributor Author

Maybe if you have time to quickly go through all of the PRs from @dj-wasabi as I think they are ready to be merged and then? For example sometime tomorrow?

I dont really mind the date as long as it suits you.

okay :)
I'm going to check the PRs from @dj-wasabi.
If all PRs have not problem, I'll rename the branch name after merging.

@dj-wasabi
Copy link
Contributor

Hi @sky-joker

Thank you! And if you could that once the PR's are merged, then that would help. Saves me from recreating the PR's.. 😄

@sky-joker
Copy link
Contributor Author

sky-joker commented Aug 9, 2020

I have done renaming the branch name to the main.
Just to be sure, I haven't removed the master branch that because we can do to be able to switchback of the branch if something problem occurs.
I'm thinking of removing the master branch after v1.0.0 released, what do you think? (I wonder if I can delete the master branch now...)

@dj-wasabi
Copy link
Contributor

Nice! 👍

I think it is fine to delete it after v1.0.0. We should only take a good look when someone creates an PR if that is for the main or master branch.

@D3DeFi
Copy link
Contributor

D3DeFi commented Aug 9, 2020

Nice, lets leave that to after 1.0.0. I bet noone will object if master stays around for a little while

@sky-joker
Copy link
Contributor Author

Thank you all :)
I understand.
I'm going to delete the master branch after the v1.0.0 release.
I close this issue and add removing a branch task to the following tasks.

#170 (comment)

@D3DeFi
Copy link
Contributor

D3DeFi commented Aug 10, 2020

Awesome, thanks 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants