Build bcrypt wheels for FreeBSD 13.1
#9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattclay
requested changes
Aug 25, 2022
Comment on lines
+6
to
+11
| - platform_tag: freebsd_12_2_release_amd64 | ||
| platform_instance: freebsd/12.2 | ||
| platform_arch: x86_64 | ||
| python: | ||
| - tag: cp38 | ||
| abi: abi3 |
There was a problem hiding this comment.
FreeBSD 12.2 is only used in stable-2.12 and stable-2.11 -- not devel. Normally we wouldn't add a non-current version here, but this is easier than manually running a build. We can remove it from the matrix once it's built.
Co-authored-by: Matt Clay <matt@mystile.com>
mattclay
approved these changes
Aug 25, 2022
webknjaz
added a commit
to webknjaz/ansible--spare-tire
that referenced
this pull request
Aug 25, 2022
This reverts commit c3bb36b.
webknjaz
added a commit
to webknjaz/ansible--spare-tire
that referenced
this pull request
Aug 25, 2022
This partially reverts commit c3bb36b.
mattclay
pushed a commit
that referenced
this pull request
Aug 25, 2022
This partially reverts commit c3bb36b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bcryptnow relies onsetuptools-rustcausing pypa/pip#6264, plus it needs a Rust compiler that is unavailable in our FreeBSD VMs.This should fix failures like https://dev.azure.com/ansible/ansible/_build/results?buildId=52061&view=logs&j=96d98051-de5a-5846-d6c0-98e63dcdbfd9&t=c2476f69-8c1f-561a-4f25-a218e506c05f&l=2635.
I'm only adding FreeBSD 13.1 to the matrix since this problem doesn't manifest itself in other VMs.