Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer-izing #97

Open
szepeviktor opened this issue Nov 23, 2019 · 3 comments · May be fixed by #98
Open

Composer-izing #97

szepeviktor opened this issue Nov 23, 2019 · 3 comments · May be fixed by #98

Comments

@szepeviktor
Copy link

szepeviktor commented Nov 23, 2019

Hello @antecedent !

Would you welcome a PR introducing class autoloading?

Composer requires PHP 5.3.2+ to run.

https://getcomposer.org/doc/00-intro.md#system-requirements

@szepeviktor
Copy link
Author

szepeviktor commented Nov 23, 2019

It would not introduce starting Patchwork.php as in #44

@antecedent
Copy link
Owner

That would be great! We do, however, need to keep some backward compatibility for now, so including Patchwork.php should still be a valid way to start Patchwork. Aside from that, it's fine and very much welcome :)

@szepeviktor szepeviktor linked a pull request Nov 24, 2019 that will close this issue
@niconoe-
Copy link

I just discovered this library today so I wanted to try it, but the lack of composer autoloading is making me impossible to use it in my current project architecture (I can't use require_once ... on my code).

I found how to bypass this by adding myself Patchwork.php in my own composer.json "autoload-dev" section, but if this could be done automagically by Patchwork itself, that would be definitly better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants