Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for phoenix 1.3 #48

Open
StefanWallin opened this issue Apr 26, 2017 · 4 comments
Open

Support for phoenix 1.3 #48

StefanWallin opened this issue Apr 26, 2017 · 4 comments

Comments

@StefanWallin
Copy link

Are you currently working on 1.3-support for the upcoming release? I tried manipulating version locks and got plain specs working, but if I try to use controller-specs or request-specs we get issues about ... Myapp.Router.Helpers is not loaded....

Opened issue for discussion and as a question. I'm quite new to the community from the Rails community and was recommended to start looking into 1.3, but it seems there are a lot of packages that don't support it yet.

@antonmi
Copy link
Owner

antonmi commented Apr 26, 2017

Thanks @StefanWallin !
Will take a look!

@antonmi
Copy link
Owner

antonmi commented May 8, 2017

Hi, @StefanWallin !
Sorry, for the late response.
Please teke a look at: https://gist.github.com/chrismccord/71ab10d433c98b714b75c886eff17357
Seems like you need to add Web namespace to the helpers.

@antonmi
Copy link
Owner

antonmi commented May 8, 2017

I'll do the changes in espec_phoenix when 1.3 stable version released

@StefanWallin
Copy link
Author

Awesome stuff! Will try it out later! Thanks for the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants