From ad497d2bbe4032f8e8d29ce4d333a962708d5511 Mon Sep 17 00:00:00 2001 From: "yihe.lxg" Date: Wed, 29 Nov 2023 15:29:10 +0800 Subject: [PATCH] fix(ava/insight): modify the methods for constructing ChangePointInfo --- .../insights/extractors/changePoint.ts | 26 ++++++++++--------- 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/packages/ava/src/insight/insights/extractors/changePoint.ts b/packages/ava/src/insight/insights/extractors/changePoint.ts index 52b35435..4cb8a0b2 100644 --- a/packages/ava/src/insight/insights/extractors/changePoint.ts +++ b/packages/ava/src/insight/insights/extractors/changePoint.ts @@ -48,19 +48,21 @@ export const getChangePointInfo: GetPatternInfo = (props) => { return getNonSignificantInsight({ insightType, infoType: 'noInsight', customInfo: { info } }); } - const outliers: ChangePointInfo[] = changePoints.map((item) => { + const outliers: ChangePointInfo[] = []; + changePoints.forEach((item) => { const { index, significance } = item; - return { - type: insightType, - dimension, - measure, - significance, - index, - // occasional abnormality: index is out of range - x: data[index]?.[dimension], - y: data[index]?.[measure] as number, - significantInsight: true, - }; + if (!isNil(data[index])) { + outliers.push({ + type: insightType, + dimension, + measure, + significance, + index, + x: data[index][dimension], + y: data[index][measure] as number, + significantInsight: true, + }); + } }); return outliers; };