Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial render size is too small causing artefacts on labels #489

Open
Alnaimi- opened this issue Jun 13, 2023 · 2 comments
Open

Partial render size is too small causing artefacts on labels #489

Alnaimi- opened this issue Jun 13, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Alnaimi-
Copy link

Alnaimi- commented Jun 13, 2023

Describe the bug

The bounded box around the canvas local refresh/render in Graphin seems to be too small for some Font Families (and or viewports depending on browser used).

I suspect the local refresh box is calculated too eagerly, so if you have a certain font family or if you use Safari, it ends up overflowing - leaving artefacts behind. See picture below.

This seem to happen more on Safari (not so frequent in Chrome).

Suggestion: We should add some padding around the local render to avoid text/image overflow.

Your Example Website or App

https://codesandbox.io/s/runtime-butterfly-z2fmlz?file=/src/App.tsx

Steps to Reproduce the Bug or Issue

  1. Open Safari browser on Mac
  2. Open the URL https://codesandbox.io/s/runtime-butterfly-z2fmlz?file=/src/App.tsx
  3. Drag the node around

Expected behavior

No artefacts should be left behind.

Screenshots or Videos

Screenshot 2023-06-13 at 13 58 13

Platform

  • OS: macOS
  • Browser: Safari
  • Version: 15.6.1 (17613.3.9.1.16)

Additional context

No response

@pomelo-nwu pomelo-nwu added the bug Something isn't working label Jun 14, 2023
@chammaaomar
Copy link

Hi there,
did you ever figure out how to resolve this? We're running into the same issue. You describe adding padding around the local render box... is there a way to achieve / hack that as a consumer of the library, without forking it or modifying its source code? Thanks for the help!

@yuri-sidoroff
Copy link

Remove custom font family from label style

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants