Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Flask-AppBuilder to 3.2.0 for improved OAUTH/LDAP #14469

Closed
thesuperzapper opened this issue Feb 25, 2021 · 2 comments · Fixed by #14665
Closed

Upgrade Flask-AppBuilder to 3.2.0 for improved OAUTH/LDAP #14469

thesuperzapper opened this issue Feb 25, 2021 · 2 comments · Fixed by #14665
Assignees
@ashb
Labels
kind:feature Feature Requests

Comments

@thesuperzapper
Copy link
Contributor

Version 3.2.0 of Flask-AppBuilder added support for LDAP group binding (see PR: dpgaspar/Flask-AppBuilder#1374), we should update mainly for the AUTH_ROLES_MAPPING feature, which lets users bind to RBAC roles based on their LDAP/OAUTH group membership.

Here are the docs about Flask-AppBuilder security:
https://flask-appbuilder.readthedocs.io/en/latest/security.html#authentication-ldap

This will resolve #8179
@thesuperzapper thesuperzapper added the kind:feature Feature Requests label Feb 25, 2021
@thesuperzapper thesuperzapper mentioned this issue Feb 26, 2021
Closed
@thesuperzapper
Copy link
Contributor Author

@potiuk are you ok with updating Flask-Appbuilder?

@thesuperzapper
Copy link
Contributor Author

@ashb can you look into this, as it will require some change to the Dockerfile (but its quite simple)

@ashb ashb self-assigned this Mar 6, 2021
@ashb ashb mentioned this issue Mar 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashb ashb

Labels
kind:feature Feature Requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Flask-AppBuilder dependency to allow 3.2 (and all 3.x series) astronomer/airflow
2 participants
@ashb @thesuperzapper