Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade FAB to 4+ #23899

Closed
1 task done
potiuk opened this issue May 24, 2022 · 6 comments
Closed
1 task done

Upgrade FAB to 4+ #23899

potiuk opened this issue May 24, 2022 · 6 comments
Labels
duplicate Issue that is duplicated kind:meta High-level information important to the community

Comments

@potiuk
Copy link
Member

potiuk commented May 24, 2022

Body

FAB 4.0.0 keeps a lot of our imporant dependencies from upgrading - including some with CVEs. We should make the effort to upgrade FAB to 4.0.0 soon to make sure we have it in 2.4.0 (or if possible even in 2.3.* line.

It has a number of UI dependencies though - including breaking changes in some libraries like PyJWT especially around authentication, so rather serious testing is needed I think.

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@potiuk potiuk added the kind:meta High-level information important to the community label May 24, 2022
@potiuk
Copy link
Member Author

potiuk commented May 24, 2022

cc: @jedcunningham @kaxil @ephraimbuddy @bbovenzi @jhtimmins

I think we get more and more pressure to get FAB 4.0.* in.

@potiuk
Copy link
Member Author

potiuk commented May 24, 2022

I looked through https://flask-appbuilder.readthedocs.io/en/latest/breaking.html#version-4-0-0 and the number of breaking changes is well, quite serious.

@dpgaspar - the changelog mostly links to changes from all the libraries that got bumped. Any comments maybe on the actual problems we might expect (I see that 4.1.1rc1 had just been released, so can we assume 4.1.1 is past the teething problems ?

@eladkal
Copy link
Contributor

eladkal commented May 24, 2022

Dup #22397 ?

@dpgaspar
Copy link
Member

I looked through https://flask-appbuilder.readthedocs.io/en/latest/breaking.html#version-4-0-0 and the number of breaking changes is well, quite serious.

@dpgaspar - the changelog mostly links to changes from all the libraries that got bumped. Any comments maybe on the actual problems we might expect (I see that 4.1.1rc1 had just been released, so can we assume 4.1.1 is past the teething problems ?

@potiuk Should be stable yes, 4.0.0 is on Apache Superset since 16 March. Here's the PR with the bump: apache/superset#19168. On other projects I found that flask-jwt-extended and pyJWT are the areas that need more attention.

In fact 4.1.1 fixes a bug introduced on 4.1.0 :)

@potiuk
Copy link
Member Author

potiuk commented May 25, 2022

Thanks Daniel. It will be definitely helpful to look at the superset change !

@potiuk potiuk changed the title Upgrade FAB to 4.0.0 Upgrade FAB to 4+ Jun 14, 2022
@potiuk
Copy link
Member Author

potiuk commented Jun 15, 2022

Dup #22397 ?

yes.

@potiuk potiuk closed this as completed Jun 15, 2022
@potiuk potiuk added the duplicate Issue that is duplicated label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issue that is duplicated kind:meta High-level information important to the community
Projects
None yet
Development

No branches or pull requests

3 participants