Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Container Instance Operator uses deprecated "network profile" arg #34820

Closed
1 of 2 tasks
jackglick opened this issue Oct 8, 2023 · 7 comments
Closed
1 of 2 tasks
Labels
area:providers kind:bug This is a clearly a bug provider:microsoft-azure Azure-related issues

Comments

@jackglick
Copy link

Apache Airflow version

2.7.1

What happened

The Azure Container Instance Operator uses the "network profile" argument which is since deprecated by Microsft: https://learn.microsoft.com/en-us/azure/container-instances/container-instances-vnet

Azure Container Instances deployed by the Operator are not deployed into a virtual network or subnet.

What you think should happen instead

Get rid of the network profile argument and replace with "vnet" and "subnet" arguments as detailed in this documentation: https://learn.microsoft.com/en-us/azure/container-instances/container-instances-vnet

How to reproduce

Deploy azure container instance - there are no longer network profiles supported by Azure. Will not let you deploy into your virtual network or subnet.

Operating System

linux

Versions of Apache Airflow Providers

No response

Deployment

Official Apache Airflow Helm Chart

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@jackglick jackglick added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Oct 8, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 8, 2023

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@Lee-W Lee-W added area:providers provider:microsoft-azure Azure-related issues and removed needs-triage label for new issues that we didn't triage yet area:core labels Oct 8, 2023
@Lee-W
Copy link
Member

Lee-W commented Oct 8, 2023

#34738 is now working on it. I think it will be included in the next azure provider release

@eladkal
Copy link
Contributor

eladkal commented Oct 10, 2023

@pankajastro I assume this issue is fixed in #34738 ?

@pankajastro
Copy link
Member

@pankajastro I assume this issue is fixed in #34738 ?

I removed network_profile in #34738 but just created a separate PR #34850 to add subnet_ids

@jackglick
Copy link
Author

@pankajastro I assume this issue is fixed in #34738 ?

I removed network_profile in #34738 but just created a separate PR #34850 to add subnet_ids

Do we also need to add in a virtual network param?

@pankajastro
Copy link
Member

pankajastro commented Oct 10, 2023

@pankajastro I assume this issue is fixed in #34738 ?

I removed network_profile in #34738 but just created a separate PR #34850 to add subnet_ids

Do we also need to add in a virtual network param?

the subnet is something like and can't see specific param for vnet in SDK

"subnetIds": [{
    "id": "[resourceId('Microsoft.Network/virtualNetworks/subnets', parameters('vnetName'), parameters('subnetName'))]"
}],

https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/containerinstance/azure-mgmt-containerinstance/generated_samples/container_groups_create_or_update.py#L83-L87

@eladkal
Copy link
Contributor

eladkal commented Oct 14, 2023

closing as task is completed and it seems more like a support question.
If further support is needed please use Github Discussion / Stackoverflow

@eladkal eladkal closed this as not planned Won't fix, can't repro, duplicate, stale Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers kind:bug This is a clearly a bug provider:microsoft-azure Azure-related issues
Projects
None yet
Development

No branches or pull requests

4 participants