Skip to content

Commit

Permalink
GH-43116: [C++][Compute] Mark KeyCompare.CompareColumnsToRowsLarge as…
Browse files Browse the repository at this point in the history
… large memory test (#43128)

### Rationale for this change

This test consumes more than 4GB memory and causes oom-kill when running with TSAN as reported in #43116 .

### What changes are included in this PR?

Limit its running by marking it as large memory test.

### Are these changes tested?

Change is test.

### Are there any user-facing changes?

None.

* GitHub Issue: #43116

Authored-by: Ruoxi Sun <zanmato1984@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
  • Loading branch information
zanmato1984 authored and raulcd committed Jul 5, 2024
1 parent e05f3d9 commit 14e4684
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions cpp/src/arrow/compute/row/compare_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -166,10 +166,9 @@ TEST(KeyCompare, CompareColumnsToRowsTempStackUsage) {
}
}

#ifndef ARROW_VALGRIND
// Compare columns to rows at offsets over 2GB within a row table.
// Certain AVX2 instructions may behave unexpectedly causing troubles like GH-41813.
TEST(KeyCompare, CompareColumnsToRowsLarge) {
TEST(KeyCompare, LARGE_MEMORY_TEST(CompareColumnsToRowsLarge)) {
if constexpr (sizeof(void*) == 4) {
GTEST_SKIP() << "Test only works on 64-bit platforms";
}
Expand Down Expand Up @@ -300,7 +299,6 @@ TEST(KeyCompare, CompareColumnsToRowsLarge) {
num_rows);
}
}
#endif // ARROW_VALGRIND

} // namespace compute
} // namespace arrow

0 comments on commit 14e4684

Please sign in to comment.