From a57642130941efbab4e66cf9231283a27b6a3c67 Mon Sep 17 00:00:00 2001 From: Rossi Sun Date: Thu, 26 Sep 2024 21:24:27 +0800 Subject: [PATCH] MINOR: [C++][Acero] Replace acero-specific append avx2 cmake macro with generic one (#44240) ### Rationale for this change Macro `append_acero_runtime_avx2_src` is duplicated with generic `append_runtime_avx2_src`. ### What changes are included in this PR? Remove `append_acero_runtime_avx2_src` and replace it with `append_runtime_avx2_src`. ### Are these changes tested? CI should be enough. ### Are there any user-facing changes? None. Authored-by: Ruoxi Sun Signed-off-by: Antoine Pitrou --- cpp/src/arrow/acero/CMakeLists.txt | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/cpp/src/arrow/acero/CMakeLists.txt b/cpp/src/arrow/acero/CMakeLists.txt index 73079059f1dfd..0a2536b11e33c 100644 --- a/cpp/src/arrow/acero/CMakeLists.txt +++ b/cpp/src/arrow/acero/CMakeLists.txt @@ -19,14 +19,6 @@ add_custom_target(arrow_acero) arrow_install_all_headers("arrow/acero") -macro(append_acero_runtime_avx2_src SRC) - if(ARROW_HAVE_RUNTIME_AVX2) - list(APPEND ARROW_ACERO_SRCS ${SRC}) - set_source_files_properties(${SRC} PROPERTIES SKIP_PRECOMPILE_HEADERS ON) - set_source_files_properties(${SRC} PROPERTIES COMPILE_FLAGS ${ARROW_AVX2_FLAG}) - endif() -endmacro() - set(ARROW_ACERO_SRCS accumulation_queue.cc scalar_aggregate_node.cc @@ -58,8 +50,8 @@ set(ARROW_ACERO_SRCS union_node.cc util.cc) -append_acero_runtime_avx2_src(bloom_filter_avx2.cc) -append_acero_runtime_avx2_src(swiss_join_avx2.cc) +append_runtime_avx2_src(ARROW_ACERO_SRCS bloom_filter_avx2.cc) +append_runtime_avx2_src(ARROW_ACERO_SRCS swiss_join_avx2.cc) set(ARROW_ACERO_SHARED_LINK_LIBS) set(ARROW_ACERO_SHARED_PRIVATE_LINK_LIBS)