MINOR: [Go][CI] Add openssl to macos CGO runs #34488
Conversation
github-actions
bot
added
awaiting committer review
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
| @@ -308,7 +308,9 @@ jobs: | |||
| run: go install honnef.co/go/tools/cmd/staticcheck@${{ matrix.staticcheck }} | |||
| - name: Build | |||
| shell: bash | |||
| run: ci/scripts/go_build.sh $(pwd) | |||
| run: | | |||
| echo "PKG_CONFIG_PATH=/usr/local/Cellar/openssl@3/3.0.8/lib/pkgconfig:$PKG_CONFIG_PATH" >> $GITHUB_ENV | |||
There was a problem hiding this comment.
This doesn't affect in this step.
We need a separated step:
- name: Prepare PKG_CONFIG_PATH
shell: bash
run: |
echo "PKG_CONFIG_PATH=$(brew --prefix openssl)/lib/pkgconfig:$PKG_CONFIG_PATH" >> $GITHUB_ENV
- name: Build
shell: bash
run: ci/scripts/go_build.sh $(pwd)
...And this change causes YAML syntax error: https://github.com/apache/arrow/actions/runs/4358242702/workflow#L308
I think that the indentation of this line is a problem.
There was a problem hiding this comment.
Ah, sorry about that. Hmm, the UI didn't seem to have shown that in the PR itself...
There was a problem hiding this comment.
Also weird how the workflow didn't run on the last commit. Sorry for the indentation error that happens due to my comment suggestion 🙈
github-actions
bot
added
awaiting changes
Fixing issue caused by #34488 Lead-authored-by: Matt Topol <zotthewizard@gmail.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
|
Benchmark runs are scheduled for baseline = 6fdf1e5 and contender = 6a4c61f. 6a4c61f is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Rationale for this change
Fix the failing CI runs