Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Update Pytest to support Python 3.10 #22471

Closed
AnandInguva opened this issue Jul 27, 2022 · 4 comments
Closed

[Task]: Update Pytest to support Python 3.10 #22471

AnandInguva opened this issue Jul 27, 2022 · 4 comments
Assignees
Labels
core done & done Issue has been reviewed after it was closed for verification, followups, etc. P2 python task

Comments

@AnandInguva
Copy link
Contributor

AnandInguva commented Jul 27, 2022

What needs to happen?

Update Pytest >= 6.2.5 to support Python 3.10 for Apache Beam Python SDK.

Issue Priority

Priority: 2

Issue Component

Component: sdk-py-core

@AnandInguva
Copy link
Contributor Author

.take-issue

@AnandInguva
Copy link
Contributor Author

AnandInguva commented Jul 27, 2022

Run XVR_JavaUsingPython_Dataflow PostCommit was failing with the Pytest update. This gradle task runs on two times sequentially, with Python 3.7 and with Python 3.9 respectively.

When Pytest gets updated, the gradle task :sdks:python:setupVirtualenv runs only for Python 3.7 and when Python 3.9 runs, :sdks:python:setupVirtualenv didn't run and it uses the cache from the previous Python run(I suspect this because, next to gradle task it says UP-TO-DATE but it shouldn't). This behavior is only observed when Pytest is updated from 4.6 to a version>=6.2.5.

For the gradle tasks that run different Python version task sequentially, --rerun-tasks can be used IIUC

@AnandInguva
Copy link
Contributor Author

.close-issue

@tvalentyn tvalentyn added the done & done Issue has been reviewed after it was closed for verification, followups, etc. label Sep 27, 2022
@svetakvsundhar
Copy link
Contributor

When Pytest gets updated, the gradle task :sdks:python:setupVirtualenv runs only for Python 3.7 and when Python 3.9 runs, :sdks:python:setupVirtualenv didn't run and it uses the cache from the previous Python run(I suspect this because, next to gradle task it says UP-TO-DATE but it shouldn't). This behavior is only observed when Pytest is updated from 4.6 to a version>=6.2.5.

@AnandInguva I'm currently observing this issue with Python 3.9 and PyTest 7.1.2. Is the current workaround to upgrade to Python 3.10?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core done & done Issue has been reviewed after it was closed for verification, followups, etc. P2 python task
Projects
None yet
Development

No branches or pull requests

3 participants