Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expected answers to DataFrame method examples #12527

Open
comphead opened this issue Sep 18, 2024 · 2 comments · May be fixed by #12564
Open

Add expected answers to DataFrame method examples #12527

comphead opened this issue Sep 18, 2024 · 2 comments · May be fixed by #12564
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@comphead
Copy link
Contributor

I feel it would benefit understanding for Dataframe methods if we also include the expected answer of calling the method in datafusion/core/src/dataframe/mod.rs

Currently we have a usage example and it would be great adding the expected answer

Originally posted by @comphead in #12520 (comment)

@comphead comphead added good first issue Good for newcomers documentation Improvements or additions to documentation labels Sep 18, 2024
@Eason0729
Copy link

Hi, I haven't contribute here before and would like to take this issue.

@Eason0729
Copy link

I have added expected result in my fork.

Could I also change doctest data to make methods' usage more apparent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants