-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Vended Credentials for Azure Data Lake Store #1146
Comments
Hi @c-thiel thank you for raising this issue. I'm not an expert in Azure Data Lake Store, but I could help look into this issue together.
It looks like the prefix for the secret name you posted is "adls" whereas the secret name we expect is "adlfs". iceberg-python/pyiceberg/io/__init__.py Line 72 in d587e67
Could you confirm if this is the case? This could be a typo on your comment above, or on the REST Catalog server side, which should be fixed |
@sungwy in my comment as well as in the catalog I am using "adls.sas-token" which is exactly what Java and Spark expect: Is there a reason for pyiceberg not using the same prefix as java? |
The adlfs prefix is wrong, we already have a PR to fix the prefix in #961 |
Thanks for pointing that out @c-thiel ! Like I mentioned, I'm not too familiar with the Azure Data Lake integration, but it looks like @ndrluis has the right solution ready for this issue 🙂 The PR has been merged into main - would be able to help confirm if the fix in main resolves this issue @c-thiel ? |
Feature Request / Improvement
Vended-Credentials for Azure Data Lake Store are supported by Java. For
getTable
/createTable
endpoints, the catalog returns a "config" that looks like:This is currently not respected by Pyiceberg. Instead we get the error:
ValueError: unable to connect to account for Must provide either a connection_string or account_name with credentials!!
Full Traceback:
The text was updated successfully, but these errors were encountered: