diff --git a/superset-frontend/packages/superset-ui-core/src/ui-overrides/ExtensionsRegistry.ts b/superset-frontend/packages/superset-ui-core/src/ui-overrides/ExtensionsRegistry.ts index dc71c809ea760..bf050a2c4c495 100644 --- a/superset-frontend/packages/superset-ui-core/src/ui-overrides/ExtensionsRegistry.ts +++ b/superset-frontend/packages/superset-ui-core/src/ui-overrides/ExtensionsRegistry.ts @@ -35,7 +35,12 @@ type ReturningDisplayable

= (props: P) => string | React.ReactElement; * When defining a new option here, take care to keep any parameters to functions (or components) minimal. * Any removal or alteration to a parameter will be considered a breaking change. */ +type ConfigDetailsProps = { + embeddedId: string; +}; + export type Extensions = Partial<{ + 'embedded.documentation.configuration_details': React.ComponentType; 'embedded.documentation.description': ReturningDisplayable; 'embedded.documentation.url': string; 'dashboard.nav.right': React.ComponentType; diff --git a/superset-frontend/src/dashboard/components/DashboardEmbedControls.tsx b/superset-frontend/src/dashboard/components/DashboardEmbedControls.tsx index dfe3f49baa455..6d28b7fd90462 100644 --- a/superset-frontend/src/dashboard/components/DashboardEmbedControls.tsx +++ b/superset-frontend/src/dashboard/components/DashboardEmbedControls.tsx @@ -148,6 +148,9 @@ export const DashboardEmbedControls = ({ dashboardId, onHide }: Props) => { return ; } + const DocsConfigDetails = extensionsRegistry.get( + 'embedded.documentation.configuration_details', + ); const docsDescription = extensionsRegistry.get( 'embedded.documentation.description', ); @@ -157,21 +160,25 @@ export const DashboardEmbedControls = ({ dashboardId, onHide }: Props) => { return ( <> -

- {embedded ? ( - <> + {embedded ? ( + DocsConfigDetails ? ( + + ) : ( +

{t( 'This dashboard is ready to embed. In your application, pass the following id to the SDK:', )}
{embedded.uuid} - - ) : ( - t( +

+ ) + ) : ( +

+ {t( 'Configure this dashboard to embed it into an external web application.', - ) - )} -

+ )} +

+ )}

{t('For further instructions, consult the')}{' '}