diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 51ccd02868901..050dc81836cbc 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1125,7 +1125,6 @@ Note the `y_axis_format` is defined under various section for some charts. | `flt_op_1` | _N/A_ | | | `goto_dash` | _N/A_ | | | `grid_size` | _N/A_ | | -| `horizon_color_scale` | _N/A_ | | | `import_time` | _N/A_ | | | `include_search` | _N/A_ | | | `include_series` | _N/A_ | | @@ -1193,7 +1192,6 @@ Note the `y_axis_format` is defined under various section for some charts. | `schema` | _N/A_ | | | `select_country` | _N/A_ | | | `series` | _N/A_ | | -| `series_height` | _N/A_ | | | `show_bar_value` | _N/A_ | | | `show_brush` | _N/A_ | | | `show_bubbles` | _N/A_ | | diff --git a/superset-frontend/src/explore/controlPanels/Horizon.js b/superset-frontend/src/explore/controlPanels/Horizon.js index 244980e411a94..529d234f36be9 100644 --- a/superset-frontend/src/explore/controlPanels/Horizon.js +++ b/superset-frontend/src/explore/controlPanels/Horizon.js @@ -18,6 +18,9 @@ */ import { t } from '@superset-ui/translation'; import { NVD3TimeSeries } from './sections'; +import { + formatSelectOptions, +} from '../../modules/utils'; export default { controlPanelSections: [ @@ -25,7 +28,48 @@ export default { { label: t('Chart Options'), expanded: true, - controlSetRows: [['series_height', 'horizon_color_scale']], + controlSetRows: [ + [ + { + name: 'series_height', + config: { + type: 'SelectControl', + renderTrigger: true, + freeForm: true, + label: t('Series Height'), + default: '25', + choices: formatSelectOptions([ + '10', + '25', + '40', + '50', + '75', + '100', + '150', + '200', + ]), + description: t('Pixel height of each series'), + }, + }, + { + name: 'horizon_color_scale', + config: { + type: 'SelectControl', + renderTrigger: true, + label: t('Value Domain'), + choices: [ + ['series', 'series'], + ['overall', 'overall'], + ['change', 'change'], + ], + default: 'series', + description: t( + 'series: Treat each series independently; overall: All series use the same scale; change: Show changes compared to the first data point in each series', + ), + }, + } + ] + ], }, ], }; diff --git a/superset-frontend/src/explore/controls.jsx b/superset-frontend/src/explore/controls.jsx index 3f229a1d22842..cbd6be3ce5227 100644 --- a/superset-frontend/src/explore/controls.jsx +++ b/superset-frontend/src/explore/controls.jsx @@ -400,21 +400,6 @@ export const controls = { ), }, - horizon_color_scale: { - type: 'SelectControl', - renderTrigger: true, - label: t('Value Domain'), - choices: [ - ['series', 'series'], - ['overall', 'overall'], - ['change', 'change'], - ], - default: 'series', - description: t( - 'series: Treat each series independently; overall: All series use the same scale; change: Show changes compared to the first data point in each series', - ), - }, - include_time: { type: 'CheckboxControl', label: t('Include Time'), @@ -1173,25 +1158,6 @@ export const controls = { description: t('Timestamp Format'), }, - series_height: { - type: 'SelectControl', - renderTrigger: true, - freeForm: true, - label: t('Series Height'), - default: '25', - choices: formatSelectOptions([ - '10', - '25', - '40', - '50', - '75', - '100', - '150', - '200', - ]), - description: t('Pixel height of each series'), - }, - page_length: { type: 'SelectControl', freeForm: true,