Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset is marked as being updated even when it is not being changed #13956

Closed
3 tasks done
john-bodley opened this issue Apr 6, 2021 · 1 comment · Fixed by #13980
Closed
3 tasks done

Dataset is marked as being updated even when it is not being changed #13956

john-bodley opened this issue Apr 6, 2021 · 1 comment · Fixed by #13980
Assignees
Labels
#bug:regression Bugs that are identified as regessions #bug Bug report

Comments

@john-bodley
Copy link
Member

john-bodley commented Apr 6, 2021

Expected results

Only edits to the dataset metadata should trigger an update to the last updated event.

Actual results

When creating a new chart from dataset (not modify any columns or metrics) the dataset is listed as being updated.

Screenshots

If applicable, add screenshots to help explain your problem.

How to reproduce the bug

  1. Create a new chart (no need to save it).
  2. Simultaneously view the datasource in /tablemodelview/list/
  3. Notice that you are listed as the person who last updated the datasource with the timestamp associated with (1).

Environment

  • superset version: master
  • python version: 3.8
  • node.js version: 14

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@john-bodley john-bodley added #bug:regression Bugs that are identified as regessions #bug Bug report labels Apr 6, 2021
@john-bodley
Copy link
Member Author

It seems if the table has a NULL extra column then upon creation of a chart a JSON encoded dictionary containing the health_check field is added resulting in an update to the record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:regression Bugs that are identified as regessions #bug Bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants