Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cosmetic]multiple cosmetic issues in Explore #14570

Closed
junlincc opened this issue May 11, 2021 · 9 comments
Closed

[cosmetic]multiple cosmetic issues in Explore #14570

junlincc opened this issue May 11, 2021 · 9 comments
Assignees
@rusackas @pkdotson
Labels
#bug:cosmetic Cosmetic/layout/design tweak needed

Comments

@junlincc
Copy link
Member

  1. spacing in between is gone..

Screen Shot 2021-05-11 at 11 00 22 AM

2. Autocomplete filter checkbox moved to the next line...

Screen Shot 2021-05-11 at 10 58 59 AM

3. Pill for column with no datatype looks funky

Screen Shot 2021-05-11 at 10 58 44 AM
@junlincc junlincc added the #bug:cosmetic Cosmetic/layout/design tweak needed label May 11, 2021
@junlincc
Copy link
Member Author

cc @rusackas

@rusackas rusackas self-assigned this May 11, 2021
@rusackas
Copy link
Member

Can't seem to repro #1. Looking into the others...

@rusackas
Copy link
Member

Not seeing #2 either, in Chrome... starting to wonder why I'm seeing something different 😜

I definitely see #3 though... on the case.

@rusackas rusackas mentioned this issue May 12, 2021
Merged
8 tasks
@rusackas
Copy link
Member

PR for #3 open: #14585 - if that's enough to close this issue (since I can't reproduce the others) let me know.

@junlincc
Copy link
Member Author

Screen Shot 2021-05-12 at 9 32 02 AM

@pkdotson can you add a few px in between? thanks 😊

@junlincc junlincc added the bash! label May 13, 2021
@pkdotson
Copy link
Member

pr is out for the explore err message: #14597

@suddjian
Copy link
Member

I am able to repro 1 and 2, will fix

@suddjian suddjian mentioned this issue May 17, 2021
Merged
8 tasks
@suddjian
Copy link
Member

fix for 2 merged #14701

@suddjian
Copy link
Member

fix for 1 merged in #14679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rusackas rusackas

@pkdotson pkdotson

Labels
#bug:cosmetic Cosmetic/layout/design tweak needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rusackas @suddjian @pkdotson @junlincc