Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Lab UI Error: Objects are not valid as a React child #19746

Closed
3 tasks
EugeneTorap opened this issue Apr 17, 2022 · 8 comments · Fixed by #19783
Closed
3 tasks

SQL Lab UI Error: Objects are not valid as a React child #19746

EugeneTorap opened this issue Apr 17, 2022 · 8 comments · Fixed by #19783
Labels
#bug Bug report

Comments

@EugeneTorap
Copy link
Contributor

EugeneTorap commented Apr 17, 2022

There are such errors in browser console.

Uncaught Error: Objects are not valid as a React child (found: object with keys {data, query}). If you meant to render a collection of children, use an array instead.

The above error occurred in the component:

How to reproduce the bug

  1. Go to SQL Lab
  2. Click on 'RUN'
  3. Click on 'Query history'
  4. See error

Expected results

No error

Actual results

There's error

Screenshots

image

Screen.Recording.2022-04-19.at.18.14.47.mov

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@EugeneTorap EugeneTorap added the #bug Bug report label Apr 17, 2022
@EugeneTorap
Copy link
Contributor Author

@rusackas @codemaster08240328 @dpgaspar @kgabryje @villebro
This #19370 PR causes this error. Should this PR revert or fix?

@EugeneTorap
Copy link
Contributor Author

@diegomedina248 Can you check your merged #19370 PR and try to fix it

@villebro
Copy link
Member

@EugeneTorap I believe this fixes the bug you've observed: #19664

@EugeneTorap
Copy link
Contributor Author

@villebro The issue occurs on current master branch. You can check it out.

@diegomedina248
Copy link
Contributor

@EugeneTorap cannot reproduce on master.
Can you share what SQL are you running?

@EugeneTorap
Copy link
Contributor Author

EugeneTorap commented Apr 19, 2022

@diegomedina248 @villebro
Updated the description, added video

@EugeneTorap
Copy link
Contributor Author

EugeneTorap commented Apr 19, 2022

@diegomedina248 Locally I have reverted your #19370 PR and the issue is fixed

@diegomedina248
Copy link
Contributor

@EugeneTorap thanks for reporting! #19783 should fix the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants