Close/remove button is broken for metrics on chart page

[marshallbrekka]

The click handler for the button to remove a metric on the chart page is throwing an exception, breaking the ability to remove metrics from a chart.

Uncaught TypeError: Cannot read properties of undefined (reading 'stopPropagation')
    at yt.onRemoveMetric (AdhocMetricOption.jsx:51:7)
    at onClick (index.tsx:313:11)
    at Object.l (react-dom.production.min.js:14:84)
    at p (react-dom.production.min.js:14:238)
    at react-dom.production.min.js:14:292
    at b (react-dom.production.min.js:15:72)
    at ot (react-dom.production.min.js:52:146)
    at rt (react-dom.production.min.js:51:255)
    at it (react-dom.production.min.js:52:334)
    at ft (react-dom.production.min.js:56:10)

How to reproduce the bug

1. Go to any chart editing page
2. Click on the "x" on the left side of a metric that is already added to the chart
3. Check the browsers dev tools/console for the exception

Expected results

Metric should be removed from the list

Actual results

The metric remains on the chart

Screenshots

Environment

(please complete the following information):

• browser type and version: Chrome 108
• superset version: docker image sha256:ce10634ba3193607cebf8628c4441bffd8a5cee8791b1394e5c5b16046a77ebf

Checklist

Make sure to follow these steps before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

The onRemoveMetric handler expects to be passed the event object
I believe this is the PR that introduced the bug, as it changed how the onRemove handler is invoked, no-longer passing the event object

[rusackas]

Thanks for the report! Pinging @michael-s-molina in regards to his linked PR, and also pinging @kgabryje as a person who often deals with this sort of control input issue, for good measure. Hopefully, we can not just fix this, but also add some tests here to harden this.

[idkm]

Hello Team,
I have the same error, can you tell me when to expect a fix?

[michael-s-molina]

Thanks for reporting this @marshallbrekka. I linked a PR to fix this bug.

[idkm]

Thank you Team, now it works as expected.