Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BarChart (Legacy) doesn't take the timerange filter on dashboard #24398

Closed
2 of 3 tasks
ShabanGerber opened this issue Jun 14, 2023 · 6 comments
Closed
2 of 3 tasks

BarChart (Legacy) doesn't take the timerange filter on dashboard #24398

ShabanGerber opened this issue Jun 14, 2023 · 6 comments

Comments

@ShabanGerber
Copy link

The timerange Filter for the BarChart (Legacy) ist not working on the dashboard.
If you have a look in the generated sql query, you can not see the timerange was not used.

How to reproduce the bug

  1. Generate a new BarChart (Legacy)
  2. Set your preferred filters
  3. Save the BarChart
  4. Add the BarChart to your dashboard
  5. Select Filter for the barchart on your dashboard e.g. 'last day'
  6. Prove the SQL Statement for this barchart
  7. You cann see that in the where clause the timerange filter is missing

Expected results

We expect that the timerange filter will be used correct.

Actual results

the timerange filter is not used in barchart

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

(please complete the following information):

  • browser type and version: Safari 114.0 (64-Bit)
  • superset version: we have updated to the current version today
  • python version: python --version
  • node.js version: node -v
  • any feature flags active:

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@sfirke
Copy link
Member

sfirke commented Jun 15, 2023

When you say you updated to the current version, is that 2.1.0? Or 0.0.0dev (master branch)? This looks like an issue that should have been fixed by this #23865 which would be on 0.0.0-dev but not 2.1.0.

@ShabanGerber
Copy link
Author

ShabanGerber commented Jun 29, 2023

Hi Sam,

first thank you for your response :)
yes we have the 0.0.0-dev branch. We will update our superset to 2.1.1 as mentioned here: #23865 and test the BarChart (Legacy) again.

When we will be finished at all. I will let you know her about our test result.

@sfirke
Copy link
Member

sfirke commented Jun 29, 2023

That sounds good. So you know, 2.1.1 is currently being tested for release as 2.1.1rc1. So if you're looking for a version to test, you could run 2.1.1rc1, or wait for 2.1.1 to be officially released (likely in the coming weeks) and test it then.

@sfirke
Copy link
Member

sfirke commented Aug 30, 2023

@ShabanGerber Superset 2.1.1 was officially released yesterday! Are you able to upgrade + see if your problem is resolved?

@rtexelm
Copy link
Member

rtexelm commented Mar 11, 2024

@rusackas might want to change the status here

@rusackas
Copy link
Member

Indeed, we're no longer officialy supporting 2.x, the legacy bar chart has been migrated away, and this thread has gone cold. Closing! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants