Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guest user (embedded) doesn't get access to datasets used only in dashboard filters #24807

Closed
3 tasks done
Vitor-Avila opened this issue Jul 26, 2023 · 0 comments · Fixed by #24808
Closed
3 tasks done

Comments

@Vitor-Avila
Copy link
Contributor

It's possible to grant dashboard access to a guest user (guest_token), by specifying the dashboard uuid in the guest_token resources. The operation grants access to all datasets used in charts added to the dashboard, however it doesn't grant access to datasets that are only used in dashboard native filters.

How to reproduce the bug

  1. Create a chart using any dataset.
  2. Save the chart and add it to a dashboard.
  3. Create a virtual dataset for the same table (a select *... would be enough).
  4. Create a dashboard filter using the virtual dataset.
  5. Enable embedded access for the dashboard.
  6. Create a guest_token and grant access to this dashboard.
  7. Access this dashboard in embedded mode.

Expected results

The dashboard filter should load properly.

Actual results

A permission error is displayed in the filter.

Screenshots

image

Environment

  • browser type and version: Google Chrome version 114.0.5735.198
  • superset version: superset version
  • python version: Superset 0.0.0-dev (running from master)
  • node.js version: v16.14.2
  • any feature flags active: EMBEDDED_SUPERSET

Checklist

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant