Closed Sqllab tabs come back with no queries after refreshing

[zhaorui2022]

If we close all the tabs in Sqllab, and then refresh the page, all the previously closed tabs are back, but there is no actual queries in them. This issue happens in 2.0.0 as well since we had users reporting this issue with the production environment which was running on 2.0.0). But in 2.0.0, the query of the last tab still shows up.

How to reproduce the bug

1. Go to Sqllab, open a few tabs and run queries
2. Close all the tabs
3. Refresh page
4. See error

Expected results

The closed tabs are gone, and it opens a brand new tab

Actual results

Closed tabs are back with no query in it

Screenshots

Environment

(please complete the following information):

• browser type and version: Chrome latest version
• superset version: superset version 3.0.0rc4
• python version: python --version 3.9
• node.js version: node -v N/A
• any feature flags active: We have SQLLAB_BACKEND_PERSISTENCE set to False, so the tabs might have been stored in browser's local storage.

Checklist

Make sure to follow these steps before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

[zhaorui2022]

I was trying to do another recording with local storage showing on the side, but found that I didn't need to close all the tabs to reproduce the issue.

[justinpark]

@zhaorui2022 it is a known issue (not a bug/regression of 3.0 nor 2.0) when PERSISTENCE_MODE sets back to false and the user has the previous persisted data, SQL Lab continuously propagates the previous persisted query editor data to NON persistence mode.
I can take a look for the hotfix.

[zhaorui2022]

Thanks.