Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting height on chart creates a larger style tag surrounding it #454

Closed
mika76 opened this issue Mar 30, 2019 · 7 comments
Closed

Setting height on chart creates a larger style tag surrounding it #454

mika76 opened this issue Mar 30, 2019 · 7 comments

Comments

@mika76
Copy link

mika76 commented Mar 30, 2019

Image

Screen Shot 2019-03-30 at 19 58 27

Explanation

  • What is the behavior you expect?
    Setting height on the chart (380px in this case) I expect the resulting chart to be exactly that height

  • What is happening instead?
    A style tag is created surrounding the chart and a min-height style is set to larger than the height (394px in this case).

@junedchhipa
Copy link
Contributor

There is some additional padding of around 14px to give some breathing space to the chart.
I will try removing it and see how it looks.

@junedchhipa
Copy link
Contributor

A new property chart.parentHeightOffset: 0 is added which will allow to remove the additional height appended.

@mika76
Copy link
Author

mika76 commented Mar 31, 2019

Thanks that would help a lot. It's hard to design panels around charts if you can't control their size.

Do you really need this at all though? Seems like people can easily add their own wrapper element and css styles if they want (eg: for padding)

@junedchhipa
Copy link
Contributor

Well, I made a mistake in the beginning by not providing inner padding which would give some breathing space by default.

Now, changing that seems difficult. So, I provided this new option to remove the extra height.

@mika76
Copy link
Author

mika76 commented Apr 2, 2019

😊 I understand, I mean you might not need the style tag at all since anybody can just wrap the chart into their own div tag and place a margin

@mrabaev48
Copy link

Hello.
I still having this issue on initial load.
I'm using Vue js 2, ts, quasar framework.

Solution with chart.parentHeightOffset: 0 doesn't help me.

Any suggestions?

image

@mika76
Copy link
Author

mika76 commented Jun 12, 2021

Hey @mrabaev48 what exactly is your issue? The picture does not explain it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants