Calling clearStore while a lazyQuery is pending causes an error

[phryneas]

Hey @jerelmiller, I get the same error stack trace error in node_modules/@apollo/client/react/hooks/useQuery.js

To reproduce the issue, go to search in the sandbox preview and press "OK" to reproduce the bug. I ran a lazy query and then quickly performed clearStore() in /src/components/Search.js to simulate it.

CodeSandbox

Thanks for looking into it!

Originally posted by @DerekWang98 in #11846 (comment)

[phryneas]

In the codesandbox we see a race condition here:

apollo-client/src/react/hooks/useLazyQuery.ts

Lines 226 to 255 in c210a03

	return new Promise<
	Omit<QueryResult<TData, TVariables>, (typeof EAGER_METHODS)[number]>
	>((resolve) => {
	let result: ApolloQueryResult<TData>;
	// Subscribe to the concast independently of the ObservableQuery in case
	// the component gets unmounted before the promise resolves. This prevents
	// the concast from terminating early and resolving with `undefined` when
	// there are no more subscribers for the concast.
	concast.subscribe({
	next: (value) => {
	result = value;
	},
	error: () => {
	resolve(
	toQueryResult(
	observable.getCurrentResult(),
	resultData.previousData,
	observable,
	client
	)
	);
	},
	complete: () => {
	resolve(
	toQueryResult(result, resultData.previousData, observable, client)
	);
	},
	});
	});

complete is called before next was called, so result remains undefined.

The question is how to best act on this:

• resolving this seems wrong as the user might expect data
• rejecting might be unexpected
• doing nothing might lead to a memory leak

We need to discuss this internally. Putting it on the agenda for our next meeting.

[github-actions]

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Client usage and allow us to serve you better.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
For general questions, we recommend using StackOverflow or our discord server.