Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for developing Apollo Server itself #1840

Closed
eberhara opened this issue Oct 21, 2018 · 4 comments
Closed

Docs for developing Apollo Server itself #1840

eberhara opened this issue Oct 21, 2018 · 4 comments
Labels
📝 documentation Focuses on changes to the documentation (docs)

Comments

@eberhara
Copy link
Contributor

Maybe there are already docs about it and I simply did not find, but here it goes anyway.

Whenever I try to contribute to apollo-server packages, I find it very difficult to test my changes against a real node (express, for example) server.

I believe we could have a better documentation on this development process.

@ghost ghost added the 📝 documentation Focuses on changes to the documentation (docs) label Oct 21, 2018
@abernix abernix changed the title Docs to run apollo-server in dev mode Docs for developing Apollo Server itself Oct 22, 2018
@capaj
Copy link

capaj commented Oct 23, 2018

there's this: https://github.com/apollographql/apollo-server#apollo-server-development

so assuming you can get npm to link it, it may be exactly what you need. Please let me know if you succeed at making the link.

@eberhara
Copy link
Contributor Author

Yeah, I've seen that, and they are correct.

However, I believe we should have a section for "development process" with more visibility than the last piece of the main readme file.

Also, we should not believe everybody has all global dependencies in order to run/compile apollo packages. Maybe it would be good to have some steps for installation + running local.

What do you think @capaj ?

@justinanastos
Copy link
Contributor

Hi @eberhara 👋! I'd love to know what other additions you think would make setting up the development process for apollo-server easier to understand.

Our goal is to make it easy for anyone to contribute; what can we add to those instructions to make it easier to follow?

@JakeDawkins
Copy link
Contributor

Thanks for the feedback! We have a plan this quarter to improve the development process around Apollo-server. I know we have a couple things in-flight around this, and we'd love to hear any suggestions you have. If you have any questions, or would like to get onboarded in the meantime, we'd love to hear from you in our spectrum community.

Since this isn't technically an issue about the product as-is, I'm going to close this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📝 documentation Focuses on changes to the documentation (docs)
Projects
None yet
Development

No branches or pull requests

5 participants