Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file upload test, handle upload in koa integration #83

Closed
wants to merge 2 commits into from
Closed

Add file upload test, handle upload in koa integration #83

wants to merge 2 commits into from

Conversation

HriBB
Copy link
Contributor

@HriBB HriBB commented Aug 5, 2016

OK, so this time the changes are more transparent. I think something got screwed up with the number of spacings.

I added a failing test to integrations.test.ts and a very naive file upload implementation to koa integration.

@helfer please review

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@helfer
Copy link
Contributor

helfer commented Aug 5, 2016

Oh, sorry, I think maybe I didn't describe clearly in the other PR: It would be great if you could separate the PR into two: one to add the failing test, then another one (on top of the first PR) which implements file upload against Koa.

Since we don't want to have failing tests on master I created a new branch against which you can make the PR: file-upload. That way we can merge the PR onto that branch and also make the HAPI, Koa and express PRs against it to get all the tests to pass before we merge into master.

Sound good?

@HriBB
Copy link
Contributor Author

HriBB commented Aug 5, 2016

Ahh OK I get it now. Did not read your instructions properly. Will fix it tomorrow.

@HriBB
Copy link
Contributor Author

HriBB commented Aug 7, 2016

Closing this PR, will continue in file-upload branch.

@HriBB HriBB closed this Aug 7, 2016
trevor-scheer added a commit that referenced this pull request May 6, 2020
chore(deps): update dependency @types/nock to v10
trevor-scheer added a commit that referenced this pull request May 14, 2020
chore(deps): update dependency @types/nock to v10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants