Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PackageSettings class doesn't work with private constructor #370

Open
talios opened this issue Mar 18, 2023 · 0 comments
Open

PackageSettings class doesn't work with private constructor #370

talios opened this issue Mar 18, 2023 · 0 comments
Labels

Comments

@talios
Copy link

talios commented Mar 18, 2023

After starting to use OpenRewrite I see that the application of the Hide Utility Class Constructor rule causes ApprovalTests to not use the PackageSettings.java class:

final class PackageSettings {
  static String ApprovalBaseDirectory = "../resources/";

  private PackageSettings() {
  }
}

Given the ApprovalBaseDirectory is static, the class shouldn't need to instantiated.

@LarsEckart LarsEckart added the bug label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants